diff options
author | MarcoFalke <falke.marco@gmail.com> | 2018-06-23 19:28:13 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2018-06-23 19:29:45 -0400 |
commit | 3a4549301ab2468cd9ae0865aa66819878ae409a (patch) | |
tree | d1eab49c2729118b990e9f2a4d98c02e82a3ffc5 /src/consensus | |
parent | 000abbb6b07410357a928768d7d56465ba0d3bac (diff) | |
parent | fa1eac9cdb1a491d5947b6972b87833792a16fe3 (diff) | |
download | bitcoin-3a4549301ab2468cd9ae0865aa66819878ae409a.tar.xz |
Merge #13512: [qa] mininode: Expose connection state through is_connected
fa1eac9cdb [qa] mininode: Expose connection state through is_connected (MarcoFalke)
Pull request description:
This gets rid of some non-type safe string comparisons and access to members that are implementation details of `class P2PConnection(asyncore.dispatcher)`. Such refactoring is required to replace the deprecated asyncore with something more sane.
Changes:
* Get rid of non-enum member `state` and replace is with bool `connected`
* Get rid of confusing argument `pushbuf` and literally just push to the buffer at the call site
Tree-SHA512: 09074c7e5ed251a2e0509ef205ab82f89887c1e1fa1cc6efc1db60d196eb2403788a4987df8809fd06d80ef652e614c5d3c3fdef70096fc5815102243388288d
Diffstat (limited to 'src/consensus')
0 files changed, 0 insertions, 0 deletions