diff options
author | fanquake <fanquake@gmail.com> | 2023-10-30 16:33:57 +0000 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-10-30 16:36:14 +0000 |
commit | 4458ae811a264968c2a7ea4bb7050eed492a7e36 (patch) | |
tree | d55cb1735c04925203c5f667abcdac44e0768f01 /src/coins.h | |
parent | 7d6c646cc79ecb7dbeed64e53606eb29cc19ff96 (diff) | |
parent | fa56067a8f56701cbda95595592e74934af7d1cd (diff) |
Merge bitcoin/bitcoin#28741: refactor: Fix bugprone-string-constructor warning
fa56067a8f56701cbda95595592e74934af7d1cd refactor: Fix bugprone-string-constructor warning (MarcoFalke)
Pull request description:
String literals in C++ have a trailing null character, so the current code is fine to rely on that implicitly. However,
* the sqlite documentation explicitly mentions the null character
* code readers may wonder if the code is intentional
* clang-tidy warns about the code via `bugprone-string-constructor`
Address the points by putting the null character into the code and enable the clang-tidy `bugprone-string-constructor` check.
ACKs for top commit:
stickies-v:
ACK fa56067a8f56701cbda95595592e74934af7d1cd
Tree-SHA512: da519184d792a885a8151ffc44c8da5781f5aaae12ef768a187cc6d9e542ca8952aebc2ec6c1a05f673f29a86ef44902ee96e7b491af7b4705ad38e14624882e
Diffstat (limited to 'src/coins.h')
0 files changed, 0 insertions, 0 deletions