diff options
| author | Gregory Maxwell <greg@xiph.org> | 2013-08-28 15:41:46 -0700 |
|---|---|---|
| committer | Gregory Maxwell <greg@xiph.org> | 2013-08-28 15:49:51 -0700 |
| commit | 9d14e689c86a395c11a530767db4ddf895446ba8 (patch) | |
| tree | b02fee2fa8d600da274cb1871bb7d7e56aad60de /src/bitcoinrpc.cpp | |
| parent | bb7d0fc12fcfbb2a91e39cb49f2a0873344dbae0 (diff) | |
| download | bitcoin-9d14e689c86a395c11a530767db4ddf895446ba8.tar.xz | |
[raw] reject insanely high fees by default in sendrawtransaction
There have been several incidents where mainnet experimentation with
raw transactions resulted in insane fees. This is hard to prevent
in the raw transaction api because the inputs may not be known.
Since sending doesn't work if the inputs aren't known, we can catch
it there.
This rejects fees > than 10000 * nMinRelayTxFee or 1 BTC with the
defaults and can be overridden with a bool at the rpc.
Diffstat (limited to 'src/bitcoinrpc.cpp')
| -rw-r--r-- | src/bitcoinrpc.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/bitcoinrpc.cpp b/src/bitcoinrpc.cpp index d22809ce69..95c0680345 100644 --- a/src/bitcoinrpc.cpp +++ b/src/bitcoinrpc.cpp @@ -1193,6 +1193,7 @@ Array RPCConvertValues(const std::string &strMethod, const std::vector<std::stri if (strMethod == "createrawtransaction" && n > 1) ConvertTo<Object>(params[1]); if (strMethod == "signrawtransaction" && n > 1) ConvertTo<Array>(params[1], true); if (strMethod == "signrawtransaction" && n > 2) ConvertTo<Array>(params[2], true); + if (strMethod == "sendrawtransaction" && n > 1) ConvertTo<bool>(params[1], true); if (strMethod == "gettxout" && n > 1) ConvertTo<boost::int64_t>(params[1]); if (strMethod == "gettxout" && n > 2) ConvertTo<bool>(params[2]); if (strMethod == "lockunspent" && n > 0) ConvertTo<bool>(params[0]); |