diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2023-02-15 12:16:08 +0000 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2023-02-15 12:21:31 +0000 |
| commit | e43ff4eab2fe13b25e50dc2b87343df347ba77c5 (patch) | |
| tree | caf2c031bff46c48714962e7468bccba334927fe /src/bech32.h | |
| parent | 68e484afbbc2e43ad7f2140275cf4e09e45b80ae (diff) | |
| parent | 9d3127b11e34131409dab7c08bde5b444d90b2cb (diff) | |
Merge bitcoin-core/gui#603: Add settings.json prune-prev, proxy-prev, onion-prev settings
9d3127b11e34131409dab7c08bde5b444d90b2cb Add settings.json prune-prev, proxy-prev, onion-prev settings (Ryan Ofsky)
Pull request description:
With #602, if proxy and pruning settings are disabled in the GUI and the GUI is restarted, proxy and prune values are not stored anywhere. So if these settings are enabled in the future, default values will be shown, not previous values.
This PR stores previous values so they will preserved across restarts. I'm not sure I like this behavior because showing default values seems simpler and safer to me. Previous values may just have been set temporarily and may have never actually worked, and it adds some code complexity to store them.
This PR is one way of resolving #596. Other solutions are possible and could be implemented as alternatives.
ACKs for top commit:
hebasto:
ACK 9d3127b11e34131409dab7c08bde5b444d90b2cb, tested on Ubuntu 22.04.
vasild:
ACK 9d3127b11e34131409dab7c08bde5b444d90b2cb
jarolrod:
tACK 9d3127b11e34131409dab7c08bde5b444d90b2cb
Tree-SHA512: 1778d1819443490c880cfd5c1711d9c5ac75ea3ee8440e2f0ced81d293247163a78ae8aba6027215110aec6533bd7dc6472aeead6796bfbd51bf2354e28f24a9
Diffstat (limited to 'src/bech32.h')
0 files changed, 0 insertions, 0 deletions