diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-06-15 18:06:14 +0200 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-06-15 18:08:51 +0200 |
| commit | 26ec2f2d6bb12525044b6d09422b42715fc09319 (patch) | |
| tree | a8b534eb9a9eb0020ce5035795fbef8e2bb78954 /src/Makefile.qt.include | |
| parent | a7a36590f590f57d46b4b904d5a8c3a1002f336d (diff) | |
| parent | a50e0b1bcb120e097a2b23dbfb71533b2f9c4d6c (diff) | |
Merge bitcoin-core/gui#618: refactor: Add `transactionoverviewwidget.cpp` source file
a50e0b1bcb120e097a2b23dbfb71533b2f9c4d6c qt, refactor: Add `transactionoverviewwidget.cpp` source file (Hennadii Stepanov)
Pull request description:
The `TransactionOverviewWidget` class was added in bitcoin-core/gui#176 as a header-only one.
Apparently, in upcoming [CMake project](https://github.com/hebasto/bitcoin/pull/3), CMake [AUTOMOC](https://cmake.org/cmake/help/latest/prop_tgt/AUTOMOC.html) could be integrated better/simpler, if `QObject`-derived class implementation been placed into a source file.
From our [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#source-code-organization):
> Implementation code should go into the `.cpp` file and not the `.h`, unless necessary due to template usage or when performance due to inlining is critical.
ACKs for top commit:
Sjors:
tACK a50e0b1bcb120e097a2b23dbfb71533b2f9c4d6c
shaavan:
ACK a50e0b1bcb120e097a2b23dbfb71533b2f9c4d6c
Tree-SHA512: 4707b6be1c5e794c4014475f826ac45ec833e472db11f12d29995f9c5a599ee98622ad54f0af72734b192144b626411c69acdafa0e6d1a390bdebfd7e570f377
Diffstat (limited to 'src/Makefile.qt.include')
| -rw-r--r-- | src/Makefile.qt.include | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/Makefile.qt.include b/src/Makefile.qt.include index 72037b3db2..b4acc47aa1 100644 --- a/src/Makefile.qt.include +++ b/src/Makefile.qt.include @@ -270,6 +270,7 @@ BITCOIN_QT_WALLET_CPP = \ qt/transactiondesc.cpp \ qt/transactiondescdialog.cpp \ qt/transactionfilterproxy.cpp \ + qt/transactionoverviewwidget.cpp \ qt/transactionrecord.cpp \ qt/transactiontablemodel.cpp \ qt/transactionview.cpp \ |