diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-05 17:28:08 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-05 17:45:09 +0100 |
| commit | ccd4db7d62e4880005da49f820a520a8943dcaed (patch) | |
| tree | ac1bb11eebffff59ce4cc95904ad7be363a62f9c /doc | |
| parent | 5d1014d5a1196ff97c1f88b6052c8bef1ebeb43e (diff) | |
| parent | fa5d7c39eb992467e43b12db213b27913374fb83 (diff) | |
| download | bitcoin-ccd4db7d62e4880005da49f820a520a8943dcaed.tar.xz | |
Merge bitcoin/bitcoin#27570: refactor: Remove need to pass chainparams to BlockManager methods
fa5d7c39eb992467e43b12db213b27913374fb83 Remove unused chainparams from BlockManager methods (MarcoFalke)
fa3f74a40efa0db3af31438e9250c41bc7406749 Replace pindex pointer with block reference (MarcoFalke)
facdb8b331da17c10b122deb28f6d71d5797f063 Add BlockManagerOpts::chainparams reference (MarcoFalke)
Pull request description:
Seems confusing to pass chainparams to each method individually, when the params can't change anyway for the whole lifetime of the block manager, and also must be equal to the ones used by the chainstate manager.
Fix this issue by removing them from the methods and instead storing a reference once in a member field.
ACKs for top commit:
dergoegge:
Code review ACK fa5d7c39eb992467e43b12db213b27913374fb83
TheCharlatan:
ACK fa5d7c39eb992467e43b12db213b27913374fb83
Tree-SHA512: b44e2466b70a2a39a46625d618ce3173897ef30418db4efb9ff73d0eb2c082633204a5586c34b95f227e6711e64f19f12d5ac0f9f34692d40cb372e98389324b
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions