diff options
author | Ava Chow <github@achow101.com> | 2024-03-22 14:43:08 -0400 |
---|---|---|
committer | Ava Chow <github@achow101.com> | 2024-03-22 14:50:58 -0400 |
commit | c1223188e0a5fb11c3a1b9224511a49dc2f848ed (patch) | |
tree | 3adc935b3793cdfd607c593663d1fddf7a1359ee /doc | |
parent | 2795e89cc5521832842534518cb744aa08fc66e4 (diff) | |
parent | 824f47294a309ba8e58ba8d1da0af15d8d828f43 (diff) | |
download | bitcoin-c1223188e0a5fb11c3a1b9224511a49dc2f848ed.tar.xz |
Merge bitcoin/bitcoin#29672: validation: Make translations of fatal errors consistent
824f47294a309ba8e58ba8d1da0af15d8d828f43 node: Use log levels in noui_ThreadSafeMessageBox (TheCharlatan)
ddc7872c08b7ddf9b1e83abdb97c21303f4a9172 node: Make translations of fatal errors consistent (TheCharlatan)
Pull request description:
The extra `bilingual_str` argument of the fatal error notifications and `node::AbortNode()` is often unused and when used usually contains the same string as the message argument. It also seems to be confusing, since it is not consistently used for errors requiring user action. For example some assumeutxo fatal errors require the user to do something, but are not translated.
So simplify the fatal error and abort node interfaces by only passing a translated string. This slightly changes the fatal errors displayed to the user.
ACKs for top commit:
stickies-v:
re-ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43
maflcko:
ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43 🔎
achow101:
ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43
hebasto:
re-ACK 824f47294a309ba8e58ba8d1da0af15d8d828f43.
Tree-SHA512: 2868ee7b045fe7f3ac582ce5039141b398480b7627734976201dafaaef7544b8461635a7292fee4a7f32ff1bfc26f9bd4d0c292dca424ba42fb7fc4483d7ce8d
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions