diff options
| author | Ava Chow <github@achow101.com> | 2024-04-23 17:13:20 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-04-23 17:20:54 -0400 |
| commit | a7129f827c9de1330dea1fec739ca210e6bda3cb (patch) | |
| tree | 82d109cfe5c3221293cfa0c92e0e3138a1c8558d /doc | |
| parent | 7c17f203a5fdc697dd1cf78a9f6c6e7f49a0567d (diff) | |
| parent | 4357158c4712d479522d5cd441ad4dd1693fdd05 (diff) | |
| download | bitcoin-a7129f827c9de1330dea1fec739ca210e6bda3cb.tar.xz | |
Merge bitcoin/bitcoin#24313: Improve display address handling for external signer
4357158c4712d479522d5cd441ad4dd1693fdd05 wallet: return and display signer error (Sjors Provoost)
dc55531087478d01fbde4f5fbb75375b672960c3 wallet: compare address returned by displayaddress (Sjors Provoost)
6c1a2cc09a00baa6ff3ff34455c2243b43067fb5 test: use h marker for external signer mock (Sjors Provoost)
Pull request description:
* HWI returns the requested address: as a sanity check, we now compare that to what we expected
* external signer documentation now reflects that HWI alternatives must implement this check
* both RPC and GUI will now return an error text, rather than just fail (the GUI even failed silently in some cases)
ACKs for top commit:
brunoerg:
ACK 4357158c4712d479522d5cd441ad4dd1693fdd05
achow101:
ACK 4357158c4712d479522d5cd441ad4dd1693fdd05
Tree-SHA512: 4f56edf3846745c8e7d08ef55cf29e8bb468256457149377c5f02da097931f9ca0c06bdbd856dc2385cde4fd11e4dc3b634c5a48814ff27f5562c8a25d43da93
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/external-signer.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/external-signer.md b/doc/external-signer.md index de44cdd880..1468e852ef 100644 --- a/doc/external-signer.md +++ b/doc/external-signer.md @@ -150,6 +150,9 @@ Example, display the first native SegWit receive address on Testnet: The command MUST be able to figure out the address type from the descriptor. +The command MUST return an object containing `{"address": "[the address]"}`. +As a sanity check, for devices that support this, it SHOULD ask the device to derive the address. + If <descriptor> contains a master key fingerprint, the command MUST fail if it does not match the fingerprint known by the device. If <descriptor> contains an xpub, the command MUST fail if it does not match the xpub known by the device. |