diff options
| author | merge-script <fanquake@gmail.com> | 2024-09-02 15:04:23 +0100 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-09-02 15:04:23 +0100 |
| commit | 99e35fb7b94ddedac176e000e5cce05e19125048 (patch) | |
| tree | 7ad91854c3460f9ab9af7ea2d084972a31e8f6b3 /doc | |
| parent | 0533e652355a68a2c52fb1524a8033bbb5bfa837 (diff) | |
| parent | ddef914bbb1e4fe87e8a85f17e4e839639fd97da (diff) | |
Merge bitcoin/bitcoin#30779: doc: add `-DWITH_BDB=ON` to unix build docs
ddef914bbb1e4fe87e8a85f17e4e839639fd97da doc: remove extraneous install statement (tdb3)
bc532c915ec6ec8ca28e0b2dd00e232f0dd8f259 doc: add with_bdb to unix build docs (tdb3)
Pull request description:
Existing instructions for building legacy wallet support omit `-DWITH_BDB=ON`, which results in:
```
CMake Warning:
Manually-specified variables were not used by the project:
BerkeleyDB_INCLUDE_DIR
```
and a build without BDB support.
This PR updates the docs to include `-DWITH_BDB=ON`.
Also adds a minor correction to the OpenBSD build doc.
Checked by building on Linux (Debian 12.7), FreeBSD 14.1, and OpenBSD 7.5 and attempting to create a legacy wallet with the `createwallet` rpc (with `-deprecatedrpc=create_bdb`).
ACKs for top commit:
l0rinc:
utACK ddef914bbb1e4fe87e8a85f17e4e839639fd97da
fanquake:
ACK ddef914bbb1e4fe87e8a85f17e4e839639fd97da
Tree-SHA512: 261568700b95fc073e03db6ca64a5f0544d5aed337aee4275575c1d0d1373c2a96911947abd202da3ed7c3b7a662b700b0596c0dabefe4b50900a798eed7e118
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/build-freebsd.md | 2 | ||||
| -rw-r--r-- | doc/build-openbsd.md | 4 | ||||
| -rw-r--r-- | doc/build-unix.md | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/doc/build-freebsd.md b/doc/build-freebsd.md index fba5a17e9a..6a25e9a834 100644 --- a/doc/build-freebsd.md +++ b/doc/build-freebsd.md @@ -118,7 +118,7 @@ Run `cmake -B build -LH` to see the full list of available options. This enables support for both wallet types, assuming `sqlite3` and `db4` are both installed. ```bash -cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" +cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON ``` ##### No Wallet or GUI diff --git a/doc/build-openbsd.md b/doc/build-openbsd.md index 32129aadf3..fafc91fc5f 100644 --- a/doc/build-openbsd.md +++ b/doc/build-openbsd.md @@ -90,7 +90,7 @@ There is an included test suite that is useful for testing code changes when dev To run the test suite (recommended), you will need to have Python 3 installed: ```bash -pkg_add install python # Select the newest version of the package. +pkg_add python # Select the newest version of the package. ``` ## Building Bitcoin Core @@ -112,7 +112,7 @@ Run `cmake -B build -LH` to see the full list of available options. This enables support for both wallet types: ```bash -cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" +cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON ``` ### 2. Compile diff --git a/doc/build-unix.md b/doc/build-unix.md index fda42ded45..4c3c659bff 100644 --- a/doc/build-unix.md +++ b/doc/build-unix.md @@ -161,7 +161,7 @@ and configure using the following: ```bash export BDB_PREFIX="/path/to/bitcoin/depends/x86_64-pc-linux-gnu" -cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" +cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON ``` **Note**: Make sure that `BDB_PREFIX` is an absolute path. |