diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-05-23 07:47:14 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-05-23 07:58:13 -0400 |
commit | 793e0ff22cbace2a0fbe1e4a2e88a7bc6bf44502 (patch) | |
tree | ffe0745ce30150cbdf97f0eae22ecb3743753da8 /doc | |
parent | 492cdc56e087c7f51f3d1e3f807191da7f9d9a07 (diff) | |
parent | fab6b9d18fd48bbbd1939b1173723bc04c5824b5 (diff) | |
download | bitcoin-793e0ff22cbace2a0fbe1e4a2e88a7bc6bf44502.tar.xz |
Merge #18698: Make g_chainman internal to validation
fab6b9d18fd48bbbd1939b1173723bc04c5824b5 validation: Mark g_chainman DEPRECATED (MarcoFalke)
fa1d97b25686a5caca623599f6d608fd08616fe8 validation: Make ProcessNewBlock*() members of ChainstateManager (MarcoFalke)
fa24d4909864096934577abc26cfa9be47f634ba validation: Make PruneOneBlockFile() a member of ChainstateManager (MarcoFalke)
fa84b1cd846f6499b741710fd478ec9ad49b5120 validation: Make LoadBlockIndex() a member of ChainstateManager (MarcoFalke)
fa05fdf0f19fa4b557cc5e9ba436e3215b83c4e6 net: Pass chainman into PeerLogicValidation (MarcoFalke)
fa7b626d7a150e5cbd4d163d2dab6f8a55fc2cc4 node: Add chainman alias for g_chainman (MarcoFalke)
Pull request description:
The global `g_chainman` has recently been introduced in #17737. The chainstate manager is primarily needed for the assumeutxo feature, but it can also simplify testing in the future.
The goal of this pull is to make the global chainstate manager internal to validation, so that all external code does not depend on globals and that unit or fuzz tests can pass in their (potentially mocked) chainstate manager.
I suggest reviewing the pull request commit-by-commit. It should be relatively straightforward refactoring that does not change behavior at all.
ACKs for top commit:
ryanofsky:
Code review ACK fab6b9d18fd48bbbd1939b1173723bc04c5824b5. Had to be rebased but still looks good
Tree-SHA512: dcbf114aeef4f8320d466369769f22ce4dd8f46a846870354df176c3de9ff17c64630fbd777e7121d7470d7a8564ed8d37b77168746e8df7489c6877e55d7b4f
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions