diff options
| author | Pieter Wuille <pieter.wuille@gmail.com> | 2017-09-11 12:59:17 -0700 |
|---|---|---|
| committer | Pieter Wuille <pieter.wuille@gmail.com> | 2017-09-11 13:00:09 -0700 |
| commit | 1afc22a7667a7a5c66b4b5d7f50832356dd5ec12 (patch) | |
| tree | 82377afbd73398d04f836dd42fcdea3858277bcd /doc | |
| parent | 31e72b284ef54c4c221015c8d700946c6143fb7a (diff) | |
| parent | 6f703e9bf11c5f2fcb0fca0e4243fce6b4b9d35a (diff) | |
| download | bitcoin-1afc22a7667a7a5c66b4b5d7f50832356dd5ec12.tar.xz | |
Merge #11100: Fix confusing blockmax{size,weight} options, dont default to throwing away money
6f703e9bf Add release notes describing blockmaxweight deprecation (Matt Corallo)
3dc263c9b Use a sensible default for blockmaxweight (Matt Corallo)
ba206d2c6 Deprecate confusing blockmaxsize, fix getmininginfo output (Matt Corallo)
Pull request description:
No sensible user will ever keep the default settings here, so not
having sensible defaults only serves to screw users who are
paying less attention, which makes for terrible defaults.
Additionally, support for block-size-limiting directly has been removed:
* This removes block-size-limiting code in favor of GBT clients
doing the limiting themselves (if at all).
* -blockmaxsize is deprecated and only used to calculate an implied
blockmaxweight, addressing confusion from multiple users.
* getmininginfo's currentblocksize return value was returning
garbage values, and has been removed, also removing a
GetSerializeSize call in some block generation inner loops and
potentially addressing some performance edge cases.
Tree-SHA512: 33010540faf5d6225ad575488b804e180a8d53a41be484ca2932a0485595e28da62f0ade4b279a6bf1c947c7ce389f51fde8651b2ba25deb25e766e0813b993c
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes.md | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/release-notes.md b/doc/release-notes.md index aa1d1bea14..46fbae0423 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -56,6 +56,22 @@ frequently tested on them. Notable changes =============== +Miner block size limiting deprecated +------------------------------------ + +Though blockmaxweight has been preferred for limiting the size of blocks returned by +getblocktemplate since 0.13.0, blockmaxsize remained as an option for those who wished +to limit their block size directly. Using this option resulted in a few UI issues as +well as non-optimal fee selection and ever-so-slightly worse performance, and has thus +now been deprecated. Further, the blockmaxsize option is now used only to calculate an +implied blockmaxweight, instead of limiting block size directly. Any miners who wish +to limit their blocks by size, instead of by weight, will have to do so manually by +removing transactions from their block template directly. + +Low-level RPC changes +---------------------- +- The "currentblocksize" value in getmininginfo has been removed. + Credits ======= |