diff options
| author | Ava Chow <github@achow101.com> | 2024-04-30 19:00:47 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-04-30 19:00:54 -0400 |
| commit | 063072b86abcb2dff4db6861b63b5b1d19e93c62 (patch) | |
| tree | d6044a0468e2f42cca2a432cae667adfddea7aa8 /doc | |
| parent | 326e563360671c568534ff72f45dec6b607e4b36 (diff) | |
| parent | 2179e2c3209a41c1419f1f5ed6270a0dad68b50d (diff) | |
| download | bitcoin-063072b86abcb2dff4db6861b63b5b1d19e93c62.tar.xz | |
Merge bitcoin/bitcoin#29813: doc: i2p: improve `-i2pacceptincoming` mention
2179e2c3209a41c1419f1f5ed6270a0dad68b50d doc: i2p: improve `-i2pacceptincoming` mention (brunoerg)
Pull request description:
In i2p documentation, it says that "the first time Bitcoin Core connects to the I2P router,
it automatically generates a persistent I2P address and its corresponding private key by
default _**or if `-i2pacceptincoming=1` is set**_". This is weird, because `-i2pacceptincoming=1`
by itself does not have any effect. Moreover, `-i2pacceptincoming` is 1 by default anyway.
ACKs for top commit:
laanwj:
This documentation change is correct and makes the documentation slightly shorter, thus easier to read. ACK 2179e2c3209a41c1419f1f5ed6270a0dad68b50d
davidgumberg:
ACK https://github.com/bitcoin/bitcoin/pull/29813/commits/2179e2c3209a41c1419f1f5ed6270a0dad68b50d
achow101:
ACK 2179e2c3209a41c1419f1f5ed6270a0dad68b50d
byaye:
ACK 2179e2c3209a41c1419f1f5ed6270a0dad68b50d
Tree-SHA512: 18a6a627343fb0aa824029d99df8a232153ba288ce94ec8c5da25693885237381fba505ea1e71c756b2a611243a302d319ca7ae03b526020cd6588710fc2ac17
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/i2p.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/i2p.md b/doc/i2p.md index b6c07388b7..b769a74df4 100644 --- a/doc/i2p.md +++ b/doc/i2p.md @@ -79,8 +79,8 @@ one of the networks has issues. ## Persistent vs transient I2P addresses The first time Bitcoin Core connects to the I2P router, it automatically -generates a persistent I2P address and its corresponding private key by default -or if `-i2pacceptincoming=1` is set. The private key is saved in a file named +generates a persistent I2P address and its corresponding private key by default, +unless `-i2pacceptincoming=0` is set. The private key is saved in a file named `i2p_private_key` in the Bitcoin Core data directory. The persistent I2P address is used for making outbound connections and accepting inbound connections. |