diff options
| author | fanquake <fanquake@gmail.com> | 2020-09-16 06:05:08 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-09-16 06:30:57 +0800 |
| commit | 1c4f59728c35dc61c213932ffa593826db10095a (patch) | |
| tree | 9b93c81b231495d4322b2a88735703cdf8539907 /doc/release-notes-19405.md | |
| parent | 62e3eb9888934189d7cdec3c0170f88e9cb05ecf (diff) | |
| parent | a8a64acaf32ac21feeb885671772282b531ef9a2 (diff) | |
| download | bitcoin-1c4f59728c35dc61c213932ffa593826db10095a.tar.xz | |
Merge #19879: [p2p] miscellaneous wtxid followups
a8a64acaf32ac21feeb885671772282b531ef9a2 [BroadcastTransaction] Remove unsafe move operator (Amiti Uttarwar)
125c0381266e0e05a408f8e1818501ab73d29110 [p2p] Remove dead code (Amiti Uttarwar)
fc66d0a65cdc52a3b259effe0c29b5eafb1b5ff5 [p2p] Check for nullptr before dereferencing pointer (Adam Jonas)
cb79b9dbf4cd06e17c8c65b36bf15c3ea2641de4 [mempool] Revert unbroadcast set to tracking just txid (Amiti Uttarwar)
Pull request description:
Addresses some outstanding review comments from #18044
- reverts unbroadcast txids to a set instead of a map (simpler, communicates intent better, takes less space, no efficiency advantages of map)
- adds safety around two touchpoints (check for nullptr before dereferencing pointer, remove an inaccurate std::move operator)
- removes some dead code
Links to comments on wtxid PR: [1](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460495254) [2](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460496023) [3](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r463532611)
thanks to jnewbery & adamjonas for flagging these ! !
ACKs for top commit:
sdaftuar:
utACK a8a64acaf32ac21feeb885671772282b531ef9a2
naumenkogs:
utACK a8a64acaf32ac21feeb885671772282b531ef9a2
jnewbery:
utACK a8a64acaf32ac21feeb885671772282b531ef9a2
Tree-SHA512: 7be669cb30cc17fb9e06b50e636ef7887c6a27354697987e4e4d38dba4b8f50e175647587430cd9bc3295bec01ce8b1e6639a50a4249d8fff9b1ca1b9ead3277
Diffstat (limited to 'doc/release-notes-19405.md')
0 files changed, 0 insertions, 0 deletions