diff options
| author | merge-script <fanquake@gmail.com> | 2024-09-05 10:36:35 +0100 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-09-05 10:36:35 +0100 |
| commit | 79772cd26ebdbd3ebb8462fb2baada7feb890729 (patch) | |
| tree | bb1a25893257af58b3921e5cd4092a080b1bf250 /doc/reduce-memory.md | |
| parent | f794a0d5f4041eb8beaff7a6f7f2867d9507dc58 (diff) | |
| parent | 556775408797d8e27154c3edaf139820b0979cce (diff) | |
Merge bitcoin/bitcoin#30743: depends: build libevent with `-D_GNU_SOURCE`
556775408797d8e27154c3edaf139820b0979cce depends: build libevent with -D_GNU_SOURCE (fanquake)
Pull request description:
Currently, builds of libevent in depends, using CMake, fail on some systems, like Alpine, with the following:
```bash
/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c: In function 'evmap_signal_add_':
/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c:456:31: error: 'NSIG' undeclared (first use in this function)
456 | if (sig < 0 || sig >= NSIG)
```
From what I can tell the `GNU_SOURCE` "detection" in libevents CMake build system, never? really worked, primarily relies on looking for a deprecated define, and it's not clear what a nice fix is. For now, always build with `_GNU_SOURCE`, to match the autotools behaviour.
ACKs for top commit:
TheCharlatan:
ACK 556775408797d8e27154c3edaf139820b0979cce
Tree-SHA512: 4552b4a92867e8fa2af0ffa39b2be6c994bf739de7ce6a7c581590be486da81f7d93fca816854548c1e912347d33a35218c441b5058c3cbd3e82c74a9b7c78d9
Diffstat (limited to 'doc/reduce-memory.md')
0 files changed, 0 insertions, 0 deletions