diff options
| author | Andrew Chow <github@achow101.com> | 2023-09-20 07:43:01 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-09-20 07:49:13 -0400 |
| commit | 3966b0a0b6b5e6110ba8106c04af1067fc6219bc (patch) | |
| tree | 35e6ad2aefe97c17985d6507909c80046063cfd0 /doc/policy | |
| parent | e9a4793b82e40631f0b8ce435375a7690bca19d0 (diff) | |
| parent | ee589d4466bb0548a6f2215afe8abd0735768dab (diff) | |
Merge bitcoin/bitcoin#28472: Remove MemPoolAccept::m_limits to avoid mutating it in package evaluation
ee589d4466bb0548a6f2215afe8abd0735768dab Add regression test for m_limit mutation (Greg Sanders)
275579d8c133c066212a26423639956e2576e97a Remove MemPoolAccept::m_limits, only have local copies for carveouts (Greg Sanders)
Pull request description:
Without remoing it, if we ever call `PreChecks()` multiple times for any reason during any one `MempoolAccept`, subsequent invocations may have incorrect limits, allowing longer/larger chains than should be allowed.
Currently this is only an issue with `submitpackage`, so this is not exposed on mainnet.
ACKs for top commit:
achow101:
ACK ee589d4466bb0548a6f2215afe8abd0735768dab
glozow:
ACK ee589d4466bb0548a6f2215afe8abd0735768dab, nits can be ignored
ariard:
Code Review ACK ee589d446
Tree-SHA512: 14cf8edc73e014220def82563f5fb4192d1c2c111829712abf16340bfbfd9a85e2148d723af6fd4995d503dd67232b48dcf8b1711668d25b5aee5eab1bdb578c
Diffstat (limited to 'doc/policy')
0 files changed, 0 insertions, 0 deletions