diff options
| author | glozow <gloriajzhao@gmail.com> | 2024-04-15 15:05:43 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2024-04-15 15:06:17 +0100 |
| commit | 07720b1cdd77399f32124641dbe1dd267eb0cf8b (patch) | |
| tree | eb0274e47f2ccbf375f2976be0b12551801385b8 /doc/developer-notes.md | |
| parent | df609a344e534a8130d8afc12204d894ae32a2f9 (diff) | |
| parent | c2e0489b7125cceaeef355fc274dd8988822fff4 (diff) | |
Merge bitcoin/bitcoin#29869: rpc, bugfix: Enforce maximum value for setmocktime
c2e0489b7125cceaeef355fc274dd8988822fff4 [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge)
Pull request description:
The maximum value for our mocktime must be representable in nanoseconds, otherwise we end up with negative values returned from `NodeClock::now()`.
Found through fuzzing:
```
$ echo "c2V0bW9ja3RpbWVcZTptYf9w/3NldG3///////////////9p////ZP///ymL//////89////Nv9L////////LXkBAABpAA==" | base64 --decode > rpc-8cab9148ab4418ebd1923c213e9d3fe9c9b49b39.crash
$ FUZZ=rpc ./src/test/fuzz/fuzz rpc-8cab9148ab4418ebd1923c213e9d3fe9c9b49b39.crash
fuzz_libfuzzer: util/time.cpp:28: static NodeClock::time_point NodeClock::now(): Assertion `ret > 0s' failed.
```
ACKs for top commit:
maflcko:
re-ACK c2e0489b7125cceaeef355fc274dd8988822fff4
brunoerg:
crACK c2e0489b7125cceaeef355fc274dd8988822fff4
glozow:
ACK c2e0489b7125cceaeef355fc274dd8988822fff4
Tree-SHA512: d7e237ca37bedd74a6b085fb6e726a142705371044c77488f593f35afe70aeca756fdba86920294b1d322c7a9b2cde9ce4e1b7d410a6ccc1fd7c6f3a6e77200a
Diffstat (limited to 'doc/developer-notes.md')
0 files changed, 0 insertions, 0 deletions