diff options
| author | fanquake <fanquake@gmail.com> | 2023-04-11 12:14:00 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-04-18 10:43:20 +0100 |
| commit | cf266b2270081f05a277ba683f00de90a741112f (patch) | |
| tree | 6331154e2c96d0ad8b29a048eba0138f828aba9e /depends | |
| parent | 5165984afcc035fd4a94c7b6b70a016097c7e673 (diff) | |
| download | bitcoin-cf266b2270081f05a277ba683f00de90a741112f.tar.xz | |
depends: Remove _LIBCPP_DEBUG from depends DEBUG mode
It was deprecated in LLVM 15, turned into a compile-time error in LLVM 16:
```bash
In file included from /usr/lib/llvm-16/bin/../include/c++/v1/cassert:19:
/usr/lib/llvm-16/bin/../include/c++/v1/__assert:22:5: error: "Defining _LIBCPP_DEBUG is not supported anymore.
Please use _LIBCPP_ENABLE_DEBUG_MODE instead."
^
1 error generated.
```
and has been removed entirely in LLVM 17 (main),
https://github.com/llvm/llvm-project/commit/ff573a42cd1f1d05508f165dc3e645a0ec17edb5.
Building libc++ in debug mode, will also automatically set
`_LIBCPP_ENABLE_DEBUG_MODE` (the new define), so adding it to depends
doesn't seem useful, and would just result in redefinition errors.
I'm wondering if as a followup, we could enable a DEBUG build of libc++
in our MSAN CI job?
Somewhat related to https://github.com/google/oss-fuzz/pull/9828, where
it looks like we'll have to sort out getting a DEBUG build of LLVM.
Diffstat (limited to 'depends')
| -rw-r--r-- | depends/hosts/linux.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/depends/hosts/linux.mk b/depends/hosts/linux.mk index 635d3d16da..1c7ee41c01 100644 --- a/depends/hosts/linux.mk +++ b/depends/hosts/linux.mk @@ -17,7 +17,7 @@ linux_release_CXXFLAGS=$(linux_release_CFLAGS) linux_debug_CFLAGS=-O1 linux_debug_CXXFLAGS=$(linux_debug_CFLAGS) -linux_debug_CPPFLAGS=-D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 +linux_debug_CPPFLAGS=-D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC ifeq (86,$(findstring 86,$(build_arch))) i686_linux_CC=gcc -m32 |