diff options
author | Murch <murch@murch.one> | 2023-08-21 15:27:23 -0400 |
---|---|---|
committer | Murch <murch@murch.one> | 2024-05-24 14:53:54 -0400 |
commit | 7aa7e30441fe77bf8e8092916e36b004bbbfe2a7 (patch) | |
tree | 8207c841c83825fa3523f14ae481f6a6704d701d /depends | |
parent | 5a5ab1d5446693ee2655860c2f2920bcc3389c83 (diff) | |
download | bitcoin-7aa7e30441fe77bf8e8092916e36b004bbbfe2a7.tar.xz |
Fold GetSelectionWaste() into ComputeAndSetWaste()
Both `GetSelectionWaste()` and `ComputeAndSetWaste()` now are part of
`SelectionResult`. Instead of `ComputeAndSetWaste()` being a wrapper for
`GetSelectionWaste()`, we combine them to a new function
`RecalculateWaste()`.
As I was combining the logic of the two functions, I noticed that
`GetSelectionWaste()` was making the odd assumption that the
`change_cost` being set to zero means that no change is created.
However, if we build transactions at a feerate of zero with the
`discard_feerate` also set to zero, we'd organically have a
`change_cost` of zero, even when we create change on a transaction.
This commit cleans up this duplicate meaning of `change_cost` and relies
on `GetChange()` to figure out whether there is change on basis of the
`min_viable_change` and whatever is left after deducting fees.
Since this broke a bunch of tests that relied on the double-meaning of
`change_cost` a bunch of tests had to be fixed.
Diffstat (limited to 'depends')
0 files changed, 0 insertions, 0 deletions