diff options
| author | merge-script <fanquake@gmail.com> | 2024-05-29 10:32:02 +0100 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-05-29 10:32:02 +0100 |
| commit | 10164916f712bd3c92f0b3ac329ba2e1209746fe (patch) | |
| tree | 864b6e6e2a50ae87a680f08ee4687cd2c51bd110 /depends/packages/packages.mk | |
| parent | 46d3477b5b18384ab022b5e122f6fba64cf4593f (diff) | |
| parent | 7c8abf3c2001152423da06d25f9f4906611685ea (diff) | |
| download | bitcoin-10164916f712bd3c92f0b3ac329ba2e1209746fe.tar.xz | |
Merge bitcoin/bitcoin#30122: bench: enable wallet creation benchmarks on all platforms
7c8abf3c2001152423da06d25f9f4906611685ea bench: bugfix, properly release wallet before erasing directory (furszy)
Pull request description:
Simple fix for #29816.
Since the wallet is appended to the global `WalletContext` during
creation, merely calling `reset()` on the benchmark shared_pointer
is insufficient to destruct the wallet. This no destruction of the
wallet object results in keeping the db connection open, which
was causes the `fs::remove_all()` failure on Windows.
ACKs for top commit:
maflcko:
utACK 7c8abf3c2001152423da06d25f9f4906611685ea
kevkevinpal:
utACK [7c8abf3](https://github.com/bitcoin/bitcoin/pull/30122/commits/7c8abf3c2001152423da06d25f9f4906611685ea)
hebasto:
re-ACK 7c8abf3c2001152423da06d25f9f4906611685ea, I agree with changes since my recent [review](https://github.com/bitcoin/bitcoin/pull/30122#pullrequestreview-2061694682).
Tree-SHA512: 279df65bea8f7aa02af0a2efed62dca9bf9b29cb748eb369c602d223e08a8a907dea7b1bffbd3dab91b1656c1d91b18a9a0534bc3f153bd751414b0e6230b3a4
Diffstat (limited to 'depends/packages/packages.mk')
0 files changed, 0 insertions, 0 deletions