aboutsummaryrefslogtreecommitdiff
path: root/db.cpp
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2011-04-04 22:24:35 -0400
committerJeff Garzik <jgarzik@pobox.com>2011-04-04 22:24:35 -0400
commitf5f1878ba104a5d6a32eeb20b341326dca6086a5 (patch)
tree39284fb8f9a1e82e7f66c49de833c2373dc54b8e /db.cpp
parent454bc86479a387893604cd662aae994d37699672 (diff)
downloadbitcoin-f5f1878ba104a5d6a32eeb20b341326dca6086a5.tar.xz
Fix deadlocks in setaccount, sendfrom RPC calls
SendMoney*() now requires caller to acquire cs_main. GetAccountAddress() now requires caller to acquire cs_main, cs_mapWallet. Ordering is intended to match these two callchains[1]: 1. CRITICAL_BLOCK(cs_main) ProcessMessage(pfrom, strCommand, vMsg) AddToWalletIfMine() AddToWallet(wtx) CRITICAL_BLOCK(cs_mapWallet) 2. CRITICAL_BLOCK(cs_main) ProcessMessage(pfrom, strCommand, vMsg) AddToWalletIfMine() AddToWallet(wtx) CRITICAL_BLOCK(cs_mapWallet) walletdb.WriteName(PubKeyToAddress(vchDefaultKey), "") CRITICAL_BLOCK(cs_mapAddressBook) Spotted by ArtForz. Additional deadlock fixes by Gavin. [1] http://www.bitcoin.org/smf/index.php?topic=4904.msg71897#msg71897
Diffstat (limited to 'db.cpp')
-rw-r--r--db.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/db.cpp b/db.cpp
index aaa997be2e..3cfcce569b 100644
--- a/db.cpp
+++ b/db.cpp
@@ -668,8 +668,8 @@ bool CWalletDB::LoadWallet()
#endif
//// todo: shouldn't we catch exceptions and try to recover and continue?
- CRITICAL_BLOCK(cs_mapKeys)
CRITICAL_BLOCK(cs_mapWallet)
+ CRITICAL_BLOCK(cs_mapKeys)
{
// Get cursor
Dbc* pcursor = GetCursor();