diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2022-01-20 12:42:56 -0500 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2022-01-20 12:43:10 -0500 |
| commit | e3ce019667fba2ec50a59814a26566fb67fa9125 (patch) | |
| tree | 98c0d21bf9c2964982b59795d7adc5d473673c6d /contrib | |
| parent | b60c477d54bba12c1d484be36f75a59ce54d534a (diff) | |
| parent | 36012ef143917f97179d3ba6599ef36a26a9a014 (diff) | |
| download | bitcoin-e3ce019667fba2ec50a59814a26566fb67fa9125.tar.xz | |
Merge bitcoin/bitcoin#23171: qa: test descriptors with mixed xpubs and const pubkeys
36012ef143917f97179d3ba6599ef36a26a9a014 qa: test descriptors with mixed xpubs and const pubkeys (Antoine Poinsot)
Pull request description:
Writing unit tests for Miniscript descriptors i noticed that `test/descriptor_tests`'s `DoCheck()` assumes that a descriptor would either contain only extended keys or only const pubkeys: if it detects an xpub in the descriptor it would assert the number of cached keys is equal to the number of keys in the descriptor, which does not hold if the descriptor also contains const (raw?) public keys since we only cache parent xpubs.
ACKs for top commit:
achow101:
ACK 36012ef143917f97179d3ba6599ef36a26a9a014
Tree-SHA512: 2ede67a6dff726bcad3e260f3deb25c9b77542ed1880eb4ad136730b741014ce950396c69c7027225de1ef27108d609bafd055188b88538ace0beb13c7e34b0b
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions