diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-08-23 18:19:25 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-08-23 18:19:52 +0200 |
| commit | dbcb5742c48fd26f77e500291d7083e12eec741b (patch) | |
| tree | a7785d1e84419e70ebe9eebbe3e770b67fd638de /contrib/signet | |
| parent | f6f7a12462b381945b1cb9bcb94b129d8fb7e289 (diff) | |
| parent | 75290ae61e37f9b7c432b59d03eca6f07f7529cd (diff) | |
| download | bitcoin-dbcb5742c48fd26f77e500291d7083e12eec741b.tar.xz | |
Merge bitcoin/bitcoin#20541: Move special CAddress-without-nTime logic to net_processing
75290ae61e37f9b7c432b59d03eca6f07f7529cd Drop us=... message in net debug for sending version message (Pieter Wuille)
5d47860334fbe0018e742d8d2a339deb11a899e8 refactor: move CAddress-without-nTime logic to net_processing (Pieter Wuille)
Pull request description:
Historically, the VERSION message contains an "addrMe" and an "addrYou". As these are sent before version negotiation is complete, the protocol version is INIT_PROTO_VERSION (209), and in that protocol, CAddress is serialized without nTime.
This is in fact the only situation left where a CAddress is (de)serialized without nTime. As it's such a simple structure (CService for ip/port + uint64_t for nServices), just inline that structure in the few places where it occurs, and remove the logic for dealing with missing nTime from CAddress.
ACKs for top commit:
Zero-1729:
crACK 75290ae61e37f9b7c432b59d03eca6f07f7529cd
jonatack:
ACK 75290ae61e37f9b7c432b59d03eca6f07f7529cd
vasild:
ACK 75290ae61e37f9b7c432b59d03eca6f07f7529cd
Tree-SHA512: ccd9f478e1766fb2ad845d512b090e6297b82100640545ca490d930785801da3b429d40400bc2eb2cbe9057d5d12362ab33f8d650a1ca9e9e85857aef36ec414
Diffstat (limited to 'contrib/signet')
0 files changed, 0 insertions, 0 deletions