aboutsummaryrefslogtreecommitdiff
path: root/contrib/macdeploy
diff options
context:
space:
mode:
authorfanquake <fanquake@gmail.com>2023-11-29 12:08:37 +0000
committerfanquake <fanquake@gmail.com>2023-12-01 10:46:19 +0000
commit308aec3e5655327d98e0428d8205d246f24d6af5 (patch)
treec65b252202a63771443d38c86fc1557fe235f274 /contrib/macdeploy
parent35537318a19360ddf1ea8f0c1e6d8ad49e635516 (diff)
build: disable external-signer for Windows
It's come to light that Boost ASIO (a Boost Process sub dep) has in some instances, been queitly initialising our network stack on Windows (see PR #28486 and discussion in #28940). This has been shielding a bug in our own code, but the larger issue is that Boost Process/ASIO is running code before main, and doing things like setting up networking. This undermines our own assumptions about how our binary works, happens before we get to run any sanity checks, and also runs before we call our own code to setup networking. It's also not clear why a feature like external signer would have a dependency that would be doing anything network/socket related, given it only exists to spawn a local process.
Diffstat (limited to 'contrib/macdeploy')
0 files changed, 0 insertions, 0 deletions