aboutsummaryrefslogtreecommitdiff
path: root/contrib/filter-lcov.py
diff options
context:
space:
mode:
authorWladimir J. van der Laan <laanwj@gmail.com>2018-06-07 08:55:26 +0200
committerWladimir J. van der Laan <laanwj@gmail.com>2018-06-07 08:56:46 +0200
commit5779dc4f76ad8a79d5e1f229a64beb5d7b8d7c84 (patch)
tree23c0aa9847f943d23ef9d04ad519ff87f50fe079 /contrib/filter-lcov.py
parente4082d59f53d25ccafb96fc829cadbdd13b25b16 (diff)
parent698cfd081144845f6246171b8a2a0cfa8daaecdb (diff)
Merge #13041: build: Add linter checking for accidental introduction of locale dependence
698cfd081144845f6246171b8a2a0cfa8daaecdb docs: Mention lint-locale-dependence.sh in developer-notes.md (practicalswift) 0a4ea2f4589961868ab4d25e0277485c31938e20 build: Add linter for checking accidental locale dependence (practicalswift) Pull request description: This linter will check for code accidentally introducing locale dependencies. Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. We should avoid using locale dependent functions if possible. Context: https://github.com/bitcoin/bitcoin/pull/12881#issuecomment-378564722 Example output: ``` $ contrib/devtools/lint-locale-dependence.sh The locale dependent function tolower(...) appears to be used: src/init.cpp: if (s[0] == '0' && std::tolower(s[1]) == 'x') { Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale dependent functions if possible. Advice not applicable in this specific case? Add an exception by updating the ignore list in contrib/devtools/lint-locale-dependence.sh ``` **Note to reviewers:** What is the most appropriate `LOCALE_DEPENDENT_FUNCTIONS` function list? What should be added or removed? Tree-SHA512: 14e448828804bb02bf59070647e38b52fce120c700c903a4a8472769a2cee5dd529bd3fc182386993cb8720482cf4250b63a0a477db61b941ae4babe5c65025f
Diffstat (limited to 'contrib/filter-lcov.py')
0 files changed, 0 insertions, 0 deletions