diff options
| author | fanquake <fanquake@gmail.com> | 2024-01-05 17:35:18 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-01-05 17:40:44 +0000 |
| commit | 04978c2e187da82081fc67772b602ab0bbc261e4 (patch) | |
| tree | 511b819992edc9b950797c22f13cbe6093fd233c /configure.ac | |
| parent | cb6d619931e8a29ad2bee034c94b9e7ff8ac0a65 (diff) | |
| parent | d83bea42d1f0ffb0899a6de3556c489543468995 (diff) | |
Merge bitcoin/bitcoin#29117: wallettool: Always be able to dump a wallet's database
d83bea42d1f0ffb0899a6de3556c489543468995 wallettool: Don't create CWallet when dumping DB (Andrew Chow)
40c80e36b1a204ed133acc403016a6cb1a92051e wallettool: Don't unilaterally reset wallet_instance if loading error (Ava Chow)
Pull request description:
https://github.com/bitcoin/bitcoin/issues/29109#issuecomment-1863449058 reports that a wallet with noncritical errors cannot be dumped with `bitcoin-wallet dump`. This was caused by an erroneous reset of the wallet pointer when the loading the wallet returns something other than `LOAD_OK`. Not all errors are errors that require aborting, so unilaterally resetting the pointer at that time is incorrect. The first commit resolves this issue.
Furthermore, if a wallet has loading errors, that should not prevent the wallet tool from dumping the wallet. The wallet application logic should not get in the way of performing such a low level database operation, especially when it's primary usage is for debugging potentially corrupted wallets. The 2nd commit is taken from #28710 and changes the `dump` to stop at making a `WalletDatabase` rather than making a `CWallet` only to retrieve the underlying `WalletDatabase`.
ACKs for top commit:
furszy:
Code review ACK d83bea42d1
BrandonOdiwuor:
Code Review ACK d83bea42d1f0ffb0899a6de3556c489543468995
Tree-SHA512: 425d712dfff1002bd81272aca0bae1016f9126a3c89506f8cb7cf0a0ec9f33d0c03b8d03896394f3a45c2998e59047e19218dfd08dc8a5f40e8625134e886b0f
Diffstat (limited to 'configure.ac')
0 files changed, 0 insertions, 0 deletions