diff options
| author | fanquake <fanquake@gmail.com> | 2023-11-13 10:52:50 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-11-13 10:57:01 +0000 |
| commit | e862bceb1705e6d8c1b738301ed10ae1b4413bfd (patch) | |
| tree | 04f0a061c4443be415cbc681cc74f2e19a119667 /ci | |
| parent | dd5f5713bccac3061676cf3814dcd4488ac557ed (diff) | |
| parent | fca0a8938e34cb4f6c400e1d1d0be02f027d80c5 (diff) | |
| download | bitcoin-e862bceb1705e6d8c1b738301ed10ae1b4413bfd.tar.xz | |
Merge bitcoin/bitcoin#27935: fuzz: call lookup functions before calling `Ban`
fca0a8938e34cb4f6c400e1d1d0be02f027d80c5 ci: remove "--exclude banman" for fuzzing in mac (brunoerg)
f9b286353f79cdb5e55e2ff4ca47d73e14f9da48 fuzz: call lookup functions before calling `Ban` (brunoerg)
Pull request description:
Fixes #27924
To not have any discrepancy, it's required to call lookup functions before calling `Ban`. If we don't do it, the assertion `assert(banmap == banmap_read);` may fail because `BanMapFromJson` will call `LookupSubNet` and cause the discrepancy between the banned and the loaded one. It happens especially in MacOS (#27924).
Also, calling lookup functions before banning is what RPC `setban` does.
ACKs for top commit:
maflcko:
lgtm ACK fca0a8938e34cb4f6c400e1d1d0be02f027d80c5
dergoegge:
ACK fca0a8938e34cb4f6c400e1d1d0be02f027d80c5
Tree-SHA512: a3d635088a556df4507e65542157f10b41d4f87dce42927b58c3b812f262f4544b6b57f3384eef1097ffdd7c32b8dd1556aae201254960cbfbf48d45551200f7
Diffstat (limited to 'ci')
| -rwxr-xr-x | ci/test/00_setup_env_mac_native.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ci/test/00_setup_env_mac_native.sh b/ci/test/00_setup_env_mac_native.sh index c9f65bf397..439fba16ef 100755 --- a/ci/test/00_setup_env_mac_native.sh +++ b/ci/test/00_setup_env_mac_native.sh @@ -15,4 +15,3 @@ export NO_DEPENDS=1 export OSX_SDK="" export CCACHE_MAXSIZE=400M export RUN_FUZZ_TESTS=true -export FUZZ_TESTS_CONFIG="--exclude banman" # https://github.com/bitcoin/bitcoin/issues/27924 |