diff options
author | fanquake <fanquake@gmail.com> | 2023-08-28 11:25:57 +0100 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-08-28 11:27:29 +0100 |
commit | db57574aa87c3c834db46d517dbd45dbf152236a (patch) | |
tree | 2462283667e07da347d6a19e1fa2253b665c74a0 /ci | |
parent | 83719146047947e588aa0c7b5eee02f44884553d (diff) | |
parent | 6a4337298035683a8748ae446eae90e5c5f41d1b (diff) |
Merge bitcoin/bitcoin#28173: ci: Run Windows native task on GitHub Actions
6a4337298035683a8748ae446eae90e5c5f41d1b ci: Run "Win64 native" job on GitHub Actions (Hennadii Stepanov)
Pull request description:
From https://github.com/bitcoin/bitcoin/issues/28098:
> Thus, someone would have to sponsor an amount of roughly 5kUSD/mo for those two tasks.
> If the goal is to stay on a free plan, I think the only option is GitHub Actions CI.
Historical context:
- https://github.com/bitcoin/bitcoin/pull/17697
- https://github.com/bitcoin/bitcoin/issues/17803
- https://github.com/bitcoin/bitcoin/pull/18031
Security concerns:
- https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1651432106
- https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1651688197
`GITHUB_TOKEN` permissions (from the build log in my personal repo):
```
2023-07-27T07:30:17.8313534Z ##[group]GITHUB_TOKEN Permissions
2023-07-27T07:30:17.8314113Z Contents: read
2023-07-27T07:30:17.8314608Z Metadata: read
2023-07-27T07:30:17.8314957Z Packages: read
2023-07-27T07:30:17.8315233Z ##[endgroup]
```
Comparison of resources:
| Resource | Current, Cirrus CI | Suggested, GitHub Actions |
|---|:-:|:-:|
| CPU | 6 | 2 |
| RAM, GB | 12 | 7 |
The `TEST_RUNNER_TIMEOUT_FACTOR` variable is set to the current default value for all CI tasks: https://github.com/bitcoin/bitcoin/blob/64440bb733896a7a2caf902825e0406cb993e666/ci/test/00_setup_env.sh#L48
Top commit has no ACKs.
Tree-SHA512: ddfdaf7a1e4793a64ac0cd20f116b29608dd06f15b062769ac70b3ea2fb82775aa96aa79c7b768efefec4338aaa5b57d267b592f62d0e8d5d94ecc11001a165d
Diffstat (limited to 'ci')
-rw-r--r-- | ci/test/wrapped-cl.bat | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ci/test/wrapped-cl.bat b/ci/test/wrapped-cl.bat deleted file mode 100644 index fc2a604c58..0000000000 --- a/ci/test/wrapped-cl.bat +++ /dev/null @@ -1 +0,0 @@ -ccache cl %* |