diff options
| author | fanquake <fanquake@gmail.com> | 2023-07-30 11:18:27 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-07-30 11:21:40 +0100 |
| commit | 64440bb733896a7a2caf902825e0406cb993e666 (patch) | |
| tree | 847dd70f0410247a68fee206d1c48f2c16e32cf9 /ci | |
| parent | 4c57e53a61e6ae65ee87a25b1355530224b5ae9e (diff) | |
| parent | fabef121b0cdfac6ec1985f6c08c5685a886ba5a (diff) | |
| download | bitcoin-64440bb733896a7a2caf902825e0406cb993e666.tar.xz | |
Merge bitcoin/bitcoin#28118: test: Add SyncWithValidationInterfaceQueue to mockscheduler RPC
fabef121b0cdfac6ec1985f6c08c5685a886ba5a refactor: Use EnsureAnyNodeContext (MarcoFalke)
fa1640617e061431059908fbf496dccca6b4e112 test: Add SyncWithValidationInterfaceQueue to mockscheduler RPC (MarcoFalke)
Pull request description:
There should be no risk or downside in adding a call to `SyncWithValidationInterfaceQueue` here. In fact, it will make tests less brittle. For example,
* If one sets the timeouts in `test/functional/feature_fee_estimation.py` to `0`, on `master` the test will fail and here it will pass.
* It may avoid a rare (theoretic) intermittent issue in https://github.com/bitcoin/bitcoin/pull/28108/files#r1268966663
ACKs for top commit:
TheCharlatan:
ACK fabef121b0cdfac6ec1985f6c08c5685a886ba5a
furszy:
Code review ACK fabef121. Convinced by checking all current tests usages.
Tree-SHA512: c9e9a536a8721d1b3f267a66b40578b34948892301affdcad121ef8e02bf17037305d0dd53aa94b1b064753e66f9cfb31823b916b707a9d812627f502b818003
Diffstat (limited to 'ci')
0 files changed, 0 insertions, 0 deletions