diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-12-14 21:00:49 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-12-14 21:03:40 +0100 |
| commit | 94a9cd25fd17e10b5720b5f72908b08c0f1ed16d (patch) | |
| tree | 8e8db466d91b5676f1732d871f4dd8b6ba05512b /ci/lint/06_script.sh | |
| parent | fff7d056a92f990ebe34ee524d0f62cdf6d13193 (diff) | |
| parent | 836a3dc02c72f917db5be386b9b4787a59d48610 (diff) | |
| download | bitcoin-94a9cd25fd17e10b5720b5f72908b08c0f1ed16d.tar.xz | |
Merge #20594: Fix getauxval calls in randomenv.cpp
836a3dc02c72f917db5be386b9b4787a59d48610 Avoid weak-linked getauxval support on non-linux platforms (like macOS) (Jonas Schnelli)
41a413b31746cc749f3c64ed8070cea9cc6cfdbe Define correct symbols for getauxval (Jonas Schnelli)
Pull request description:
PR #20358 made use of the two preprocessor symbols `HAVE_STRONG_GETAUXVAL` as well as `HAVE_WEAK_GETAUXVAL`.
These symbols have not been defined in configure.ac. They where only passed selective as CRC32 CPPFLAGS in https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.crc32c.include#L16.
PR #20358 would have broken the macOS build since `getauxval` is not supported on macOS (but weak-linking does pass).
This PR defines the two symbols correctly and reduces calls to `getauxval` to linux.
ACKs for top commit:
laanwj:
Code review ACK 836a3dc02c72f917db5be386b9b4787a59d48610
jonatack:
utACK 836a3dc02c72f917db5be386b9b4787a59d48610
Tree-SHA512: 6527f4a617b937f4c368a3cb1c162f1ac38a6f5e6341295554961eaf322906e9b27398a6f7b00819854ceebb5c828d3e6ce0a779edd769adc4053ce8beda3739
Diffstat (limited to 'ci/lint/06_script.sh')
0 files changed, 0 insertions, 0 deletions