diff options
| author | Ava Chow <github@achow101.com> | 2024-08-06 20:11:38 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-08-06 20:11:38 -0400 |
| commit | ce1c881ccc8ff9017099352fd4f66d0554338d61 (patch) | |
| tree | 52d8ebd5d498cbef7154d66876a386e60eae7ca0 /INSTALL.md | |
| parent | bb25e0691f656b7a971e0fb4d52ddda9eb4a2604 (diff) | |
| parent | 6714276d72244c2e2dbe9617f1341ba7fc06c0cc (diff) | |
Merge bitcoin/bitcoin#30577: miniscript: Use `ToIntegral` instead of `ParseInt64`
6714276d72244c2e2dbe9617f1341ba7fc06c0cc miniscript: Use `ToIntegral` instead of `ParseInt64` (brunoerg)
Pull request description:
Currently, miniscript code uses `ParseInt64` function for `after`, `older`, `multi` and `thresh` fragments. It means that a leading `+` or whitespace, among other things, are accepted into the fragments. However, these cases are not useful and cause Bitcoin Core to behave differently compared to other miniscript implementations (see https://github.com/brunoerg/bitcoinfuzz/issues/34). This PR fixes it.
ACKs for top commit:
achow101:
ACK 6714276d72244c2e2dbe9617f1341ba7fc06c0cc
tdb3:
cr ACK 6714276d72244c2e2dbe9617f1341ba7fc06c0cc
danielabrozzoni:
tACK 6714276d72244c2e2dbe9617f1341ba7fc06c0cc
darosior:
utACK 6714276d72244c2e2dbe9617f1341ba7fc06c0cc
Tree-SHA512: d9eeb93f380f346d636513eeaf26865285e7b0907b8ed258fe1e02153a9eb69d484c82180eb1c78b0ed77ad5f0e5b244be6672c2f890b1d9fddc9e844bee6dde
Diffstat (limited to 'INSTALL.md')
0 files changed, 0 insertions, 0 deletions