diff options
| author | Ava Chow <github@achow101.com> | 2024-06-11 15:24:49 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-06-11 15:24:49 -0400 |
| commit | 2251460f3efc68af9891505757280b773db68a09 (patch) | |
| tree | e20ec7c37fc1ae6022667a6b74ea3e35d026d4e5 /COPYING | |
| parent | 337f9d44c28b1d3563a0063a8805b418d506698d (diff) | |
| parent | 09ef322acc0a88a9e119f74923399598984c68f6 (diff) | |
| download | bitcoin-2251460f3efc68af9891505757280b773db68a09.tar.xz | |
Merge bitcoin/bitcoin#28830: [refactor] Check CTxMemPool options in ctor
09ef322acc0a88a9e119f74923399598984c68f6 [[refactor]] Check CTxMemPool options in constructor (TheCharlatan)
Pull request description:
The tests should run the same checks on the mempool options that the init code also applies. The downside to this patch is that the log line may now be printed more than once in the for loop.
This was originally noticed here https://github.com/bitcoin/bitcoin/pull/25290#discussion_r900272797.
ACKs for top commit:
stickies-v:
re-ACK 09ef322acc0a88a9e119f74923399598984c68f6 . Fixed unreachable assert and updated docstring, and also added an exception for "-maxmempool must be at least " in the `tx_pool` fuzz test, which makes sense when looking at how the mempool options are constructed in `SetMempoolConstraints`.
achow101:
ACK 09ef322acc0a88a9e119f74923399598984c68f6
ryanofsky:
Code review ACK 09ef322acc0a88a9e119f74923399598984c68f6. Just fuzz test error checking fix and updated comment since last review
Tree-SHA512: eb3361411c2db70be17f912e3b14d9cb9c60fb0697a1eded952c3b7e8675b7d783780d45c52e091931d1d80fe0f0280cee98dd57a3100def13af20259d9d1b9e
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions