diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-07 15:49:51 +0200 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-07 16:03:55 +0200 |
| commit | 97ba72117cb717bd7bed53133ad623d4e991b220 (patch) | |
| tree | 5c72b4f45a759e0de44fcb97f120513e59f00659 /CONTRIBUTING.md | |
| parent | be443328037162f265cc85d05b1a7665b5f104d2 (diff) | |
| parent | 5197660e947435e510ef3ef72be8be8dee3ffa41 (diff) | |
Merge bitcoin/bitcoin#27401: tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings
5197660e947435e510ef3ef72be8be8dee3ffa41 tracepoints: Disables `-Wgnu-zero-variadic-macro-arguments` to compile without warnings (Martin Leitner-Ankerl)
Pull request description:
Fixes #26916 by disabling the warning `-Wgnu-zero-variadic-macro-arguments` when clang is used as the compiler.
Also see the comments
* Proposed changes in the bug https://github.com/bitcoin/bitcoin/issues/26916#issuecomment-1480997053
* Proposed changes when moving to a variadic maro: https://github.com/bitcoin/bitcoin/pull/26593#discussion_r1155488768
ACKs for top commit:
hebasto:
ACK 5197660e947435e510ef3ef72be8be8dee3ffa41, I've reconsidered my [comment](https://github.com/bitcoin/bitcoin/pull/27401#issuecomment-1507142439) and I think the current localized approach is optimal.
fanquake:
ACK 5197660e947435e510ef3ef72be8be8dee3ffa41 - checked that this fixes the warnings under Clang.
Tree-SHA512: c3dda3bcbb2540af6283ffff65885a9937bfdaaef3b00dc7d60b9f9740031d5c36ac9cb3d3d8756dbadce4812201a9754f5b8770df0d5e0d5ee690ba8a7135d2
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions