diff options
| author | Ava Chow <github@achow101.com> | 2024-02-13 12:58:16 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-02-13 13:08:30 -0500 |
| commit | 128b4a80387d322a7810d8716eccdac95ff9b8cd (patch) | |
| tree | d51c8877c078fa1cace99c8b4686edb9a93c1446 /CONTRIBUTING.md | |
| parent | d7dabdbfcd4de560bb7a2ba1d326999c0e3c249f (diff) | |
| parent | 77331aa2a198b708372a5c6cdf331faf7e2968ef (diff) | |
| download | bitcoin-128b4a80387d322a7810d8716eccdac95ff9b8cd.tar.xz | |
Merge bitcoin/bitcoin#29403: wallet: batch erase procedures and improve 'EraseRecords' performance
77331aa2a198b708372a5c6cdf331faf7e2968ef wallet: simplify EraseRecords by using 'ErasePrefix' (furszy)
33757814ceb04102141d3fd5ef2f87abf0422310 wallet: bdb batch 'ErasePrefix', do not create txn internally (furszy)
cf4d72a75e9603e947b3d47e1f3ac7c7f37bb401 wallet: db, introduce 'RunWithinTxn()' helper function (furszy)
Pull request description:
Seeks to optimize and simplify `WalletBatch::EraseRecords`. Currently, this process opens a cursor to iterate over the entire database, searching for records that match the type prefixes, to then call the `WalletBatch::Erase` function for each of the matching records.
This PR rewrites this 40-line manual process into a single line; instead of performing all of those actions manually, we can simply utilize the `ErasePrefix()` functionality. The result is 06216b344dea6ad6c385fda0b37808ff9ae5273b.
Moreover, it expands the test coverage for the `ErasePrefix` functionality and documents the db txn requirement for `BerkeleyBatch::ErasePrefix` .
ACKs for top commit:
achow101:
reACK 77331aa2a198b708372a5c6cdf331faf7e2968ef
josibake:
code review ACK https://github.com/bitcoin/bitcoin/pull/29403/commits/77331aa2a198b708372a5c6cdf331faf7e2968ef
Tree-SHA512: 9f78dda658677ff19b5979ba0efd11cf9fabf3d315feb79ed1160526f010fe843c41903fc18c0b092f78aa88bc874cf24edad8fc1ea6e96aabdc4fd1daf21ca5
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions