diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-22 09:48:51 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-22 09:52:27 +0100 |
| commit | f998eb766227d55a7a6da876971fd2a28374eee8 (patch) | |
| tree | 78f618bd9f0a3a5674c52f9484628c09a0babdf3 | |
| parent | 9a8318f30ba7da7798990cfa7c3017d2382da3cf (diff) | |
| parent | 6a936580d1c42576f627d5fac5423ec7af88e547 (diff) | |
| download | bitcoin-f998eb766227d55a7a6da876971fd2a28374eee8.tar.xz | |
Merge bitcoin/bitcoin#27683: ci: remove `RUN_SECURITY_TESTS`
6a936580d1c42576f627d5fac5423ec7af88e547 ci: remove RUN_SECURITY_TESTS (fanquake)
Pull request description:
We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case). The CI environment doesn't (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don't match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953.
ACKs for top commit:
josibake:
code review ACK https://github.com/bitcoin/bitcoin/pull/27683/commits/6a936580d1c42576f627d5fac5423ec7af88e547
TheCharlatan:
ACK 6a936580d1c42576f627d5fac5423ec7af88e547
Tree-SHA512: c0eec61a4b873bac487ba9321b50116a215b4796bd7d416d98ffcd09969dbf635c2cb5aeb225c89d1e6462838fa2a48565048ebe730f48d76d3db46b64855a91
| -rwxr-xr-x | ci/test/00_setup_env.sh | 1 | ||||
| -rwxr-xr-x | ci/test/06_script_b.sh | 4 |
2 files changed, 0 insertions, 5 deletions
diff --git a/ci/test/00_setup_env.sh b/ci/test/00_setup_env.sh index 4a54f47b03..d98f05ca6b 100755 --- a/ci/test/00_setup_env.sh +++ b/ci/test/00_setup_env.sh @@ -37,7 +37,6 @@ export USE_BUSY_BOX=${USE_BUSY_BOX:-false} export RUN_UNIT_TESTS=${RUN_UNIT_TESTS:-true} export RUN_FUNCTIONAL_TESTS=${RUN_FUNCTIONAL_TESTS:-true} export RUN_TIDY=${RUN_TIDY:-false} -export RUN_SECURITY_TESTS=${RUN_SECURITY_TESTS:-false} # By how much to scale the test_runner timeouts (option --timeout-factor). # This is needed because some ci machines have slow CPU or disk, so sanitizers # might be slow or a reindex might be waiting on disk IO. diff --git a/ci/test/06_script_b.sh b/ci/test/06_script_b.sh index 8604d8e842..83da4dac32 100755 --- a/ci/test/06_script_b.sh +++ b/ci/test/06_script_b.sh @@ -173,10 +173,6 @@ if [ "${RUN_TIDY}" = "true" ]; then git --no-pager diff fi -if [ "$RUN_SECURITY_TESTS" = "true" ]; then - make test-security-check -fi - if [ "$RUN_FUZZ_TESTS" = "true" ]; then bash -c "LD_LIBRARY_PATH=${DEPENDS_DIR}/${HOST}/lib test/fuzz/test_runner.py ${FUZZ_TESTS_CONFIG} $MAKEJOBS -l DEBUG ${DIR_FUZZ_IN}" fi |