aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbrunoerg <brunoely.gc@gmail.com>2024-06-25 14:28:55 -0300
committerbrunoerg <brunoely.gc@gmail.com>2024-06-26 06:16:17 -0300
commitc838e3b6106adfe3fe3173aaf5b0a7dee023adce (patch)
tree50c5d73b83fa23128a05f8b1ef05bce4351ac90a
parent323b0acfcb9380ce4b3c12a3d0b341d7bb3bfe08 (diff)
downloadbitcoin-c838e3b6106adfe3fe3173aaf5b0a7dee023adce.tar.xz
test: add coverage for `node` field of `getaddednodeinfo` RPC
-rwxr-xr-xtest/functional/rpc_net.py9
1 files changed, 8 insertions, 1 deletions
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py
index 2701d2471d..9fcd3957bf 100755
--- a/test/functional/rpc_net.py
+++ b/test/functional/rpc_net.py
@@ -249,11 +249,18 @@ class NetTest(BitcoinTestFramework):
added_nodes = self.nodes[0].getaddednodeinfo()
assert_equal(len(added_nodes), 1)
assert_equal(added_nodes[0]['addednode'], ip_port)
+ # check that filtering by node works
+ self.nodes[0].addnode(node="11.22.33.44", command='add')
+ first_added_node = self.nodes[0].getaddednodeinfo(node=ip_port)
+ assert_equal(added_nodes, first_added_node)
+ assert_equal(len(self.nodes[0].getaddednodeinfo()), 2)
# check that node cannot be added again
assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port, command='add')
# check that node can be removed
self.nodes[0].addnode(node=ip_port, command='remove')
- assert_equal(self.nodes[0].getaddednodeinfo(), [])
+ added_nodes = self.nodes[0].getaddednodeinfo()
+ assert_equal(len(added_nodes), 1)
+ assert_equal(added_nodes[0]['addednode'], "11.22.33.44")
# check that an invalid command returns an error
assert_raises_rpc_error(-1, 'addnode "node" "command"', self.nodes[0].addnode, node=ip_port, command='abc')
# check that trying to remove the node again returns an error