diff options
| author | fanquake <fanquake@gmail.com> | 2023-02-28 15:24:31 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-02-28 15:34:23 +0000 |
| commit | c37fb251f5a85ef20505cbca6a05038eef4d779e (patch) | |
| tree | 255b1d49d525dadc413a1c6136ea31a910a79942 | |
| parent | bb136aaf2c3bb862bf126751b0aeae62d695eaf7 (diff) | |
| parent | fb0dbe94233ec509570cbba3118cf62d8e60842b (diff) | |
| download | bitcoin-c37fb251f5a85ef20505cbca6a05038eef4d779e.tar.xz | |
Merge bitcoin/bitcoin#27176: docs: GetDataDirNet and GetDataDirBase don't create datadir
fb0dbe94233ec509570cbba3118cf62d8e60842b docs: GetDataDirNet and GetDataDirBase don't create datadir (stickies-v)
Pull request description:
Since #27073, the behaviour of `GetDataDir()` [changed](https://github.com/bitcoin/bitcoin/pull/27073/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216L435-L443) to only return the datadir path, but not create it if non-existent. This also changed the behaviour of `GetDataDirNet()` and `GetDataDirBase()` but the docs do not yet reflect that.
ACKs for top commit:
TheCharlatan:
ACK fb0dbe94233ec509570cbba3118cf62d8e60842b
theStack:
ACK fb0dbe94233ec509570cbba3118cf62d8e60842b
willcl-ark:
ACK fb0dbe942
Tree-SHA512: 3f10f4871df59882f3649c6d3b2362cae2f8a01ad0bd0c636c5608b0d177d279a2e8712930b819d6d3912e91fa6447b9e54507c33d8afe427f7f39002b013bfb
| -rw-r--r-- | src/util/system.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/util/system.h b/src/util/system.h index 14f093501a..cb3d76ece5 100644 --- a/src/util/system.h +++ b/src/util/system.h @@ -287,7 +287,6 @@ protected: * Get data directory path * * @return Absolute path on success, otherwise an empty path when a non-directory path would be returned - * @post Returned directory path is created unless it is empty */ const fs::path& GetDataDirBase() const { return GetDataDir(false); } @@ -295,7 +294,6 @@ protected: * Get data directory path with appended network identifier * * @return Absolute path on success, otherwise an empty path when a non-directory path would be returned - * @post Returned directory path is created unless it is empty */ const fs::path& GetDataDirNet() const { return GetDataDir(true); } |