diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-02-06 12:53:47 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-02-06 12:53:56 +0100 |
| commit | c3451483d28381dd86ed89bfd62f99c6ba979986 (patch) | |
| tree | 0f76fd2656822d8e0b5c3bba272544e970e7324d | |
| parent | 9a32114626fca1f4d14cb53fcd54b65d2e48ff5b (diff) | |
| parent | eeeb416d73789758bdfa6c86cd8791b0c2e3de6e (diff) | |
| download | bitcoin-c3451483d28381dd86ed89bfd62f99c6ba979986.tar.xz | |
Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build.
eeeb416 Remove suggestion to make cloned repository world-writable for Windows build. (murrayn)
Pull request description:
Current documentation for Windows build on Ubuntu suggests cloning the repository into /usr/src, as root, and making the tree world-writable(!). I can see no problem this solves, and it introduces obvious security issues.
Tree-SHA512: 05429a64319c046f5506f7d27c64c94f94cfe6d14ec5f01dccf843fc417e954fe96e1abc43126b9204a1178f101e4a8da9eece32b5de4b348c7c9358615c7e0f
| -rw-r--r-- | doc/build-windows.md | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/doc/build-windows.md b/doc/build-windows.md index 9e0e66e522..8d4afdc817 100644 --- a/doc/build-windows.md +++ b/doc/build-windows.md @@ -102,11 +102,9 @@ Note that for WSL the Bitcoin Core source path MUST be somewhere in the default example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail. This means you cannot use a directory that located directly on the host Windows file system to perform the build. -The next three steps are an example of how to acquire the source in an appropriate way. +Acquire the source in the usual way: - cd /usr/src - sudo git clone https://github.com/bitcoin/bitcoin.git - sudo chmod -R a+rw bitcoin + git clone https://github.com/bitcoin/bitcoin.git Once the source code is ready the build steps are below. @@ -132,11 +130,9 @@ Note that for WSL the Bitcoin Core source path MUST be somewhere in the default example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail. This means you cannot use a directory that located directly on the host Windows file system to perform the build. -The next three steps are an example of how to acquire the source in an appropriate way. +Acquire the source in the usual way: - cd /usr/src - sudo git clone https://github.com/bitcoin/bitcoin.git - sudo chmod -R a+rw bitcoin + git clone https://github.com/bitcoin/bitcoin.git Then build using: |