diff options
| author | fanquake <fanquake@gmail.com> | 2023-07-26 09:44:01 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-07-26 09:58:33 +0100 |
| commit | c2ff87e1fa35e1edfa434ac6f341a141d3545257 (patch) | |
| tree | d91ce182d29f4d043d48db3859504d128969c531 | |
| parent | 4517e2f4d43302606af712c9982c2520a4eeb62a (diff) | |
| parent | faca9a3d5a6887517d02b994a43d0e1101b718bc (diff) | |
Merge bitcoin/bitcoin#28150: test: Avoid intermittent issues due to async events in validationinterface_tests
faca9a3d5a6887517d02b994a43d0e1101b718bc test: Avoid intermittent issues due to async events in validationinterface_tests (MarcoFalke)
Pull request description:
Currently the tests have many issues:
* They setup the genesis block, even though it is not needed
* They queue an async `UpdatedBlockTip` even, which causes intermittent issues: https://github.com/bitcoin/bitcoin/issues/28146#issuecomment-1650064645
Fix all issues by trimming down the setup to just `ChainTestingSetup`.
ACKs for top commit:
Crypt-iQ:
tACK faca9a3d5a6887517d02b994a43d0e1101b718bc
Tree-SHA512: 4449040330f89bbaf5ce5b2052417c160b451c373987fdf1069596c07834ed81f0aea1506d53c7d2cd21062b27332d30679285dae194b272fd0cb9ce5ded32cf
| -rw-r--r-- | src/test/validationinterface_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/validationinterface_tests.cpp b/src/test/validationinterface_tests.cpp index 576768a625..fcd0b25b38 100644 --- a/src/test/validationinterface_tests.cpp +++ b/src/test/validationinterface_tests.cpp @@ -12,7 +12,7 @@ #include <atomic> -BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, TestingSetup) +BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, ChainTestingSetup) struct TestSubscriberNoop final : public CValidationInterface { void BlockChecked(const CBlock&, const BlockValidationState&) override {} |