aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Corallo <git@bluematt.me>2019-01-17 14:48:25 +1000
committerSuhas Daftuar <sdaftuar@gmail.com>2019-05-02 11:00:19 -0400
commitb8b4c80146780f9011abbd1be72343cc965c07b9 (patch)
treef96b9894a37d073925dd0f0321631661f8ccc254
parent8818729013e17c650a25f030b2b80e0997389155 (diff)
downloadbitcoin-b8b4c80146780f9011abbd1be72343cc965c07b9.tar.xz
[refactor] drop IsInvalid(nDoSOut)
Co-authored-by: Anthony Towns <aj@erisian.com.au>
-rw-r--r--src/consensus/validation.h7
-rw-r--r--src/test/txvalidation_tests.cpp4
2 files changed, 0 insertions, 11 deletions
diff --git a/src/consensus/validation.h b/src/consensus/validation.h
index 36142e1e41..163b17e629 100644
--- a/src/consensus/validation.h
+++ b/src/consensus/validation.h
@@ -71,13 +71,6 @@ public:
bool IsError() const {
return mode == MODE_ERROR;
}
- bool IsInvalid(int &nDoSOut) const {
- if (IsInvalid()) {
- nDoSOut = nDoS;
- return true;
- }
- return false;
- }
bool CorruptionPossible() const {
return corruptionPossible;
}
diff --git a/src/test/txvalidation_tests.cpp b/src/test/txvalidation_tests.cpp
index c2777cd6d1..4876c44f10 100644
--- a/src/test/txvalidation_tests.cpp
+++ b/src/test/txvalidation_tests.cpp
@@ -52,10 +52,6 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_reject_coinbase, TestChain100Setup)
// Check that the validation state reflects the unsuccessful attempt.
BOOST_CHECK(state.IsInvalid());
BOOST_CHECK_EQUAL(state.GetRejectReason(), "coinbase");
-
- int nDoS;
- BOOST_CHECK_EQUAL(state.IsInvalid(nDoS), true);
- BOOST_CHECK_EQUAL(nDoS, 100);
}
BOOST_AUTO_TEST_SUITE_END()