aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnthony Towns <aj@erisian.com.au>2021-02-15 23:04:21 +1000
committerAnthony Towns <aj@erisian.com.au>2021-02-26 23:55:07 +1000
commit81dd57e5b1ab1afa7e59468e30ef41bd34f0c8d7 (patch)
treef72b8a881133c56daec1a2dc6b9c1cd41267f126
parent9d5313df7eedad8562c822f5477747e924929fd3 (diff)
downloadbitcoin-81dd57e5b1ab1afa7e59468e30ef41bd34f0c8d7.tar.xz
txorphanage: Pass uint256 by reference instead of value
-rw-r--r--src/txorphanage.cpp4
-rw-r--r--src/txorphanage.h2
2 files changed, 3 insertions, 3 deletions
diff --git a/src/txorphanage.cpp b/src/txorphanage.cpp
index fb03914681..d418ed9323 100644
--- a/src/txorphanage.cpp
+++ b/src/txorphanage.cpp
@@ -22,9 +22,9 @@ std::map<uint256, std::map<uint256, COrphanTx>::iterator> g_orphans_by_wtxid GUA
std::vector<std::map<uint256, COrphanTx>::iterator> g_orphan_list GUARDED_BY(g_cs_orphans);
-int EraseOrphanTx(uint256 hash)
+int EraseOrphanTx(const uint256& txid)
{
- std::map<uint256, COrphanTx>::iterator it = mapOrphanTransactions.find(hash);
+ std::map<uint256, COrphanTx>::iterator it = mapOrphanTransactions.find(txid);
if (it == mapOrphanTransactions.end())
return 0;
for (const CTxIn& txin : it->second.tx->vin)
diff --git a/src/txorphanage.h b/src/txorphanage.h
index d97b4b1f43..343f12c9c5 100644
--- a/src/txorphanage.h
+++ b/src/txorphanage.h
@@ -23,7 +23,7 @@ struct COrphanTx {
size_t list_pos;
};
-int EraseOrphanTx(uint256 hash) EXCLUSIVE_LOCKS_REQUIRED(g_cs_orphans);
+int EraseOrphanTx(const uint256& txid) EXCLUSIVE_LOCKS_REQUIRED(g_cs_orphans);
void EraseOrphansFor(NodeId peer);
unsigned int LimitOrphanTxSize(unsigned int nMaxOrphans);