aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormerge-script <90386131+bitcoin-core-merge-script@users.noreply.github.com>2023-02-13 15:31:50 +0100
committermerge-script <90386131+bitcoin-core-merge-script@users.noreply.github.com>2023-02-13 15:31:50 +0100
commit8126551d54ffd290ed5767248be4b3d19243787b (patch)
tree4f61fa8d82eb1ee4eecd9633963cdd864ad8a8e0
parent141115a0604001b8cce848804798dc174770a994 (diff)
parent561848aaf2d67791e92754f3d11813bc53959a8f (diff)
Merge bitcoin/bitcoin#27011: Add simulation-based `CCoinsViewCache` fuzzer
561848aaf2d67791e92754f3d11813bc53959a8f Exercise non-DIRTY spent coins in caches in fuzz test (Pieter Wuille) 59e6828bb5b56a2354a80059d3f660f551f3e207 Add deterministic mode to CCoinsViewCache (Pieter Wuille) b0ff31084006ac7d4a7afba3190ca75f5f8441af Add CCoinsViewCache::SanityCheck() and use it in fuzz test (Pieter Wuille) 3c9cea1340fd1358d6854209d782922864945eb0 Add simulation-based CCoinsViewCache fuzzer (Pieter Wuille) Pull request description: The fuzzer goes through a sequence of operations that get applied to both a real stack of `CCoinsViewCache` objects, and to simulation data, comparing the two at the end. ACKs for top commit: jamesob: re-ACK https://github.com/bitcoin/bitcoin/pull/27011/commits/561848aaf2d67791e92754f3d11813bc53959a8f dergoegge: Code review ACK 561848aaf2d67791e92754f3d11813bc53959a8f Tree-SHA512: 68634f251fdb39436b128ecba093f651bff12ac11508dc9885253e57fd21efd44edf3b22b0f821c228175ec507df7d46c7f9f5404fc1eb8187fdbd136a5d5ee2
-rw-r--r--src/Makefile.test.include1
-rw-r--r--src/coins.cpp24
-rw-r--r--src/coins.h8
-rw-r--r--src/test/fuzz/coins_view.cpp2
-rw-r--r--src/test/fuzz/coinscache_sim.cpp478
-rw-r--r--src/util/hasher.cpp5
-rw-r--r--src/util/hasher.h2
7 files changed, 514 insertions, 6 deletions
diff --git a/src/Makefile.test.include b/src/Makefile.test.include
index 4d867fdc2f..d6992640ff 100644
--- a/src/Makefile.test.include
+++ b/src/Makefile.test.include
@@ -248,6 +248,7 @@ test_fuzz_fuzz_SOURCES = \
test/fuzz/chain.cpp \
test/fuzz/checkqueue.cpp \
test/fuzz/coins_view.cpp \
+ test/fuzz/coinscache_sim.cpp \
test/fuzz/connman.cpp \
test/fuzz/crypto.cpp \
test/fuzz/crypto_aes256.cpp \
diff --git a/src/coins.cpp b/src/coins.cpp
index e98bf816ab..5a6ae525a7 100644
--- a/src/coins.cpp
+++ b/src/coins.cpp
@@ -32,7 +32,10 @@ bool CCoinsViewBacked::BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock,
std::unique_ptr<CCoinsViewCursor> CCoinsViewBacked::Cursor() const { return base->Cursor(); }
size_t CCoinsViewBacked::EstimateSize() const { return base->EstimateSize(); }
-CCoinsViewCache::CCoinsViewCache(CCoinsView* baseIn) : CCoinsViewBacked(baseIn) {}
+CCoinsViewCache::CCoinsViewCache(CCoinsView* baseIn, bool deterministic) :
+ CCoinsViewBacked(baseIn), m_deterministic(deterministic),
+ cacheCoins(0, SaltedOutpointHasher(/*deterministic=*/deterministic))
+{}
size_t CCoinsViewCache::DynamicMemoryUsage() const {
return memusage::DynamicUsage(cacheCoins) + cachedCoinsUsage;
@@ -311,7 +314,24 @@ void CCoinsViewCache::ReallocateCache()
// Cache should be empty when we're calling this.
assert(cacheCoins.size() == 0);
cacheCoins.~CCoinsMap();
- ::new (&cacheCoins) CCoinsMap();
+ ::new (&cacheCoins) CCoinsMap(0, SaltedOutpointHasher(/*deterministic=*/m_deterministic));
+}
+
+void CCoinsViewCache::SanityCheck() const
+{
+ size_t recomputed_usage = 0;
+ for (const auto& [_, entry] : cacheCoins) {
+ unsigned attr = 0;
+ if (entry.flags & CCoinsCacheEntry::DIRTY) attr |= 1;
+ if (entry.flags & CCoinsCacheEntry::FRESH) attr |= 2;
+ if (entry.coin.IsSpent()) attr |= 4;
+ // Only 5 combinations are possible.
+ assert(attr != 2 && attr != 4 && attr != 7);
+
+ // Recompute cachedCoinsUsage.
+ recomputed_usage += entry.coin.DynamicMemoryUsage();
+ }
+ assert(recomputed_usage == cachedCoinsUsage);
}
static const size_t MIN_TRANSACTION_OUTPUT_WEIGHT = WITNESS_SCALE_FACTOR * ::GetSerializeSize(CTxOut(), PROTOCOL_VERSION);
diff --git a/src/coins.h b/src/coins.h
index 710b8c7c83..dd336b210a 100644
--- a/src/coins.h
+++ b/src/coins.h
@@ -211,6 +211,9 @@ public:
/** CCoinsView that adds a memory cache for transactions to another CCoinsView */
class CCoinsViewCache : public CCoinsViewBacked
{
+private:
+ const bool m_deterministic;
+
protected:
/**
* Make mutable so that we can "fill the cache" even from Get-methods
@@ -223,7 +226,7 @@ protected:
mutable size_t cachedCoinsUsage{0};
public:
- CCoinsViewCache(CCoinsView *baseIn);
+ CCoinsViewCache(CCoinsView *baseIn, bool deterministic = false);
/**
* By deleting the copy constructor, we prevent accidentally using it when one intends to create a cache on top of a base cache.
@@ -320,6 +323,9 @@ public:
//! See: https://stackoverflow.com/questions/42114044/how-to-release-unordered-map-memory
void ReallocateCache();
+ //! Run an internal sanity check on the cache data structure. */
+ void SanityCheck() const;
+
private:
/**
* @note this is marked const, but may actually append to `cacheCoins`, increasing
diff --git a/src/test/fuzz/coins_view.cpp b/src/test/fuzz/coins_view.cpp
index e75dc3ce91..e80c772aa4 100644
--- a/src/test/fuzz/coins_view.cpp
+++ b/src/test/fuzz/coins_view.cpp
@@ -46,7 +46,7 @@ FUZZ_TARGET_INIT(coins_view, initialize_coins_view)
{
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
CCoinsView backend_coins_view;
- CCoinsViewCache coins_view_cache{&backend_coins_view};
+ CCoinsViewCache coins_view_cache{&backend_coins_view, /*deterministic=*/true};
COutPoint random_out_point;
Coin random_coin;
CMutableTransaction random_mutable_transaction;
diff --git a/src/test/fuzz/coinscache_sim.cpp b/src/test/fuzz/coinscache_sim.cpp
new file mode 100644
index 0000000000..f350c9d032
--- /dev/null
+++ b/src/test/fuzz/coinscache_sim.cpp
@@ -0,0 +1,478 @@
+// Copyright (c) 2023 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <coins.h>
+#include <crypto/sha256.h>
+#include <primitives/transaction.h>
+#include <test/fuzz/fuzz.h>
+#include <test/fuzz/FuzzedDataProvider.h>
+#include <test/fuzz/util.h>
+
+#include <assert.h>
+#include <optional>
+#include <memory>
+#include <stdint.h>
+#include <vector>
+
+namespace {
+
+/** Number of distinct COutPoint values used in this test. */
+constexpr uint32_t NUM_OUTPOINTS = 256;
+/** Number of distinct Coin values used in this test (ignoring nHeight). */
+constexpr uint32_t NUM_COINS = 256;
+/** Maximum number CCoinsViewCache objects used in this test. */
+constexpr uint32_t MAX_CACHES = 4;
+/** Data type large enough to hold NUM_COINS-1. */
+using coinidx_type = uint8_t;
+
+struct PrecomputedData
+{
+ //! Randomly generated COutPoint values.
+ COutPoint outpoints[NUM_OUTPOINTS];
+
+ //! Randomly generated Coin values.
+ Coin coins[NUM_COINS];
+
+ PrecomputedData()
+ {
+ static const uint8_t PREFIX_O[1] = {'o'}; /** Hash prefix for outpoint hashes. */
+ static const uint8_t PREFIX_S[1] = {'s'}; /** Hash prefix for coins scriptPubKeys. */
+ static const uint8_t PREFIX_M[1] = {'m'}; /** Hash prefix for coins nValue/fCoinBase. */
+
+ for (uint32_t i = 0; i < NUM_OUTPOINTS; ++i) {
+ uint32_t idx = (i * 1200U) >> 12; /* Map 3 or 4 entries to same txid. */
+ const uint8_t ser[4] = {uint8_t(idx), uint8_t(idx >> 8), uint8_t(idx >> 16), uint8_t(idx >> 24)};
+ CSHA256().Write(PREFIX_O, 1).Write(ser, sizeof(ser)).Finalize(outpoints[i].hash.begin());
+ outpoints[i].n = i;
+ }
+
+ for (uint32_t i = 0; i < NUM_COINS; ++i) {
+ const uint8_t ser[4] = {uint8_t(i), uint8_t(i >> 8), uint8_t(i >> 16), uint8_t(i >> 24)};
+ uint256 hash;
+ CSHA256().Write(PREFIX_S, 1).Write(ser, sizeof(ser)).Finalize(hash.begin());
+ /* Convert hash to scriptPubkeys (of different lengths, so SanityCheck's cached memory
+ * usage check has a chance to detect mismatches). */
+ switch (i % 5U) {
+ case 0: /* P2PKH */
+ coins[i].out.scriptPubKey.resize(25);
+ coins[i].out.scriptPubKey[0] = OP_DUP;
+ coins[i].out.scriptPubKey[1] = OP_HASH160;
+ coins[i].out.scriptPubKey[2] = 20;
+ std::copy(hash.begin(), hash.begin() + 20, coins[i].out.scriptPubKey.begin() + 3);
+ coins[i].out.scriptPubKey[23] = OP_EQUALVERIFY;
+ coins[i].out.scriptPubKey[24] = OP_CHECKSIG;
+ break;
+ case 1: /* P2SH */
+ coins[i].out.scriptPubKey.resize(23);
+ coins[i].out.scriptPubKey[0] = OP_HASH160;
+ coins[i].out.scriptPubKey[1] = 20;
+ std::copy(hash.begin(), hash.begin() + 20, coins[i].out.scriptPubKey.begin() + 2);
+ coins[i].out.scriptPubKey[12] = OP_EQUAL;
+ break;
+ case 2: /* P2WPKH */
+ coins[i].out.scriptPubKey.resize(22);
+ coins[i].out.scriptPubKey[0] = OP_0;
+ coins[i].out.scriptPubKey[1] = 20;
+ std::copy(hash.begin(), hash.begin() + 20, coins[i].out.scriptPubKey.begin() + 2);
+ break;
+ case 3: /* P2WSH */
+ coins[i].out.scriptPubKey.resize(34);
+ coins[i].out.scriptPubKey[0] = OP_0;
+ coins[i].out.scriptPubKey[1] = 32;
+ std::copy(hash.begin(), hash.begin() + 32, coins[i].out.scriptPubKey.begin() + 2);
+ break;
+ case 4: /* P2TR */
+ coins[i].out.scriptPubKey.resize(34);
+ coins[i].out.scriptPubKey[0] = OP_1;
+ coins[i].out.scriptPubKey[1] = 32;
+ std::copy(hash.begin(), hash.begin() + 32, coins[i].out.scriptPubKey.begin() + 2);
+ break;
+ }
+ /* Hash again to construct nValue and fCoinBase. */
+ CSHA256().Write(PREFIX_M, 1).Write(ser, sizeof(ser)).Finalize(hash.begin());
+ coins[i].out.nValue = CAmount(hash.GetUint64(0) % MAX_MONEY);
+ coins[i].fCoinBase = (hash.GetUint64(1) & 7) == 0;
+ coins[i].nHeight = 0; /* Real nHeight used in simulation is set dynamically. */
+ }
+ }
+};
+
+enum class EntryType : uint8_t
+{
+ /* This entry in the cache does not exist (so we'd have to look in the parent cache). */
+ NONE,
+
+ /* This entry in the cache corresponds to an unspent coin. */
+ UNSPENT,
+
+ /* This entry in the cache corresponds to a spent coin. */
+ SPENT,
+};
+
+struct CacheEntry
+{
+ /* Type of entry. */
+ EntryType entrytype;
+
+ /* Index in the coins array this entry corresponds to (only if entrytype == UNSPENT). */
+ coinidx_type coinidx;
+
+ /* nHeight value for this entry (so the coins[coinidx].nHeight value is ignored; only if entrytype == UNSPENT). */
+ uint32_t height;
+};
+
+struct CacheLevel
+{
+ CacheEntry entry[NUM_OUTPOINTS];
+
+ void Wipe() {
+ for (uint32_t i = 0; i < NUM_OUTPOINTS; ++i) {
+ entry[i].entrytype = EntryType::NONE;
+ }
+ }
+};
+
+/** Class for the base of the hierarchy (roughly simulating a memory-backed CCoinsViewDB).
+ *
+ * The initial state consists of the empty UTXO set, though coins whose output index
+ * is 3 (mod 5) always have GetCoin() succeed (but returning an IsSpent() coin unless a UTXO
+ * exists). Coins whose output index is 4 (mod 5) have GetCoin() always succeed after being spent.
+ * This exercises code paths with spent, non-DIRTY cache entries.
+ */
+class CoinsViewBottom final : public CCoinsView
+{
+ std::map<COutPoint, Coin> m_data;
+
+public:
+ bool GetCoin(const COutPoint& outpoint, Coin& coin) const final
+ {
+ auto it = m_data.find(outpoint);
+ if (it == m_data.end()) {
+ if ((outpoint.n % 5) == 3) {
+ coin.Clear();
+ return true;
+ }
+ return false;
+ } else {
+ coin = it->second;
+ return true;
+ }
+ }
+
+ bool HaveCoin(const COutPoint& outpoint) const final
+ {
+ return m_data.count(outpoint);
+ }
+
+ uint256 GetBestBlock() const final { return {}; }
+ std::vector<uint256> GetHeadBlocks() const final { return {}; }
+ std::unique_ptr<CCoinsViewCursor> Cursor() const final { return {}; }
+ size_t EstimateSize() const final { return m_data.size(); }
+
+ bool BatchWrite(CCoinsMap& data, const uint256&, bool erase) final
+ {
+ for (auto it = data.begin(); it != data.end(); it = erase ? data.erase(it) : std::next(it)) {
+ if (it->second.flags & CCoinsCacheEntry::DIRTY) {
+ if (it->second.coin.IsSpent() && (it->first.n % 5) != 4) {
+ m_data.erase(it->first);
+ } else if (erase) {
+ m_data[it->first] = std::move(it->second.coin);
+ } else {
+ m_data[it->first] = it->second.coin;
+ }
+ } else {
+ /* For non-dirty entries being written, compare them with what we have. */
+ auto it2 = m_data.find(it->first);
+ if (it->second.coin.IsSpent()) {
+ assert(it2 == m_data.end() || it2->second.IsSpent());
+ } else {
+ assert(it2 != m_data.end());
+ assert(it->second.coin.out == it2->second.out);
+ assert(it->second.coin.fCoinBase == it2->second.fCoinBase);
+ assert(it->second.coin.nHeight == it2->second.nHeight);
+ }
+ }
+ }
+ return true;
+ }
+};
+
+} // namespace
+
+FUZZ_TARGET(coinscache_sim)
+{
+ /** Precomputed COutPoint and CCoins values. */
+ static const PrecomputedData data;
+
+ /** Dummy coinsview instance (base of the hierarchy). */
+ CoinsViewBottom bottom;
+ /** Real CCoinsViewCache objects. */
+ std::vector<std::unique_ptr<CCoinsViewCache>> caches;
+ /** Simulated cache data (sim_caches[0] matches bottom, sim_caches[i+1] matches caches[i]). */
+ CacheLevel sim_caches[MAX_CACHES + 1];
+ /** Current height in the simulation. */
+ uint32_t current_height = 1U;
+
+ // Initialize bottom simulated cache.
+ sim_caches[0].Wipe();
+
+ /** Helper lookup function in the simulated cache stack. */
+ auto lookup = [&](uint32_t outpointidx, int sim_idx = -1) -> std::optional<std::pair<coinidx_type, uint32_t>> {
+ uint32_t cache_idx = sim_idx == -1 ? caches.size() : sim_idx;
+ while (true) {
+ const auto& entry = sim_caches[cache_idx].entry[outpointidx];
+ if (entry.entrytype == EntryType::UNSPENT) {
+ return {{entry.coinidx, entry.height}};
+ } else if (entry.entrytype == EntryType::SPENT) {
+ return std::nullopt;
+ };
+ if (cache_idx == 0) break;
+ --cache_idx;
+ }
+ return std::nullopt;
+ };
+
+ /** Flush changes in top cache to the one below. */
+ auto flush = [&]() {
+ assert(caches.size() >= 1);
+ auto& cache = sim_caches[caches.size()];
+ auto& prev_cache = sim_caches[caches.size() - 1];
+ for (uint32_t outpointidx = 0; outpointidx < NUM_OUTPOINTS; ++outpointidx) {
+ if (cache.entry[outpointidx].entrytype != EntryType::NONE) {
+ prev_cache.entry[outpointidx] = cache.entry[outpointidx];
+ cache.entry[outpointidx].entrytype = EntryType::NONE;
+ }
+ }
+ };
+
+ // Main simulation loop: read commands from the fuzzer input, and apply them
+ // to both the real cache stack and the simulation.
+ FuzzedDataProvider provider(buffer.data(), buffer.size());
+ LIMITED_WHILE(provider.remaining_bytes(), 10000) {
+ // Every operation (except "Change height") moves current height forward,
+ // so it functions as a kind of epoch, making ~all UTXOs unique.
+ ++current_height;
+ // Make sure there is always at least one CCoinsViewCache.
+ if (caches.empty()) {
+ caches.emplace_back(new CCoinsViewCache(&bottom, /*deterministic=*/true));
+ sim_caches[caches.size()].Wipe();
+ }
+
+ // Execute command.
+ CallOneOf(
+ provider,
+
+ [&]() { // GetCoin
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Look up in simulation data.
+ auto sim = lookup(outpointidx);
+ // Look up in real caches.
+ Coin realcoin;
+ auto real = caches.back()->GetCoin(data.outpoints[outpointidx], realcoin);
+ // Compare results.
+ if (!sim.has_value()) {
+ assert(!real || realcoin.IsSpent());
+ } else {
+ assert(real && !realcoin.IsSpent());
+ const auto& simcoin = data.coins[sim->first];
+ assert(realcoin.out == simcoin.out);
+ assert(realcoin.fCoinBase == simcoin.fCoinBase);
+ assert(realcoin.nHeight == sim->second);
+ }
+ },
+
+ [&]() { // HaveCoin
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Look up in simulation data.
+ auto sim = lookup(outpointidx);
+ // Look up in real caches.
+ auto real = caches.back()->HaveCoin(data.outpoints[outpointidx]);
+ // Compare results.
+ assert(sim.has_value() == real);
+ },
+
+ [&]() { // HaveCoinInCache
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Invoke on real cache (there is no equivalent in simulation, so nothing to compare result with).
+ (void)caches.back()->HaveCoinInCache(data.outpoints[outpointidx]);
+ },
+
+ [&]() { // AccessCoin
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Look up in simulation data.
+ auto sim = lookup(outpointidx);
+ // Look up in real caches.
+ const auto& realcoin = caches.back()->AccessCoin(data.outpoints[outpointidx]);
+ // Compare results.
+ if (!sim.has_value()) {
+ assert(realcoin.IsSpent());
+ } else {
+ assert(!realcoin.IsSpent());
+ const auto& simcoin = data.coins[sim->first];
+ assert(simcoin.out == realcoin.out);
+ assert(simcoin.fCoinBase == realcoin.fCoinBase);
+ assert(realcoin.nHeight == sim->second);
+ }
+ },
+
+ [&]() { // AddCoin (only possible_overwrite if necessary)
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ uint32_t coinidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_COINS - 1);
+ // Look up in simulation data (to know whether we must set possible_overwrite or not).
+ auto sim = lookup(outpointidx);
+ // Invoke on real caches.
+ Coin coin = data.coins[coinidx];
+ coin.nHeight = current_height;
+ caches.back()->AddCoin(data.outpoints[outpointidx], std::move(coin), sim.has_value());
+ // Apply to simulation data.
+ auto& entry = sim_caches[caches.size()].entry[outpointidx];
+ entry.entrytype = EntryType::UNSPENT;
+ entry.coinidx = coinidx;
+ entry.height = current_height;
+ },
+
+ [&]() { // AddCoin (always possible_overwrite)
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ uint32_t coinidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_COINS - 1);
+ // Invoke on real caches.
+ Coin coin = data.coins[coinidx];
+ coin.nHeight = current_height;
+ caches.back()->AddCoin(data.outpoints[outpointidx], std::move(coin), true);
+ // Apply to simulation data.
+ auto& entry = sim_caches[caches.size()].entry[outpointidx];
+ entry.entrytype = EntryType::UNSPENT;
+ entry.coinidx = coinidx;
+ entry.height = current_height;
+ },
+
+ [&]() { // SpendCoin (moveto = nullptr)
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Invoke on real caches.
+ caches.back()->SpendCoin(data.outpoints[outpointidx], nullptr);
+ // Apply to simulation data.
+ sim_caches[caches.size()].entry[outpointidx].entrytype = EntryType::SPENT;
+ },
+
+ [&]() { // SpendCoin (with moveto)
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Look up in simulation data (to compare the returned *moveto with).
+ auto sim = lookup(outpointidx);
+ // Invoke on real caches.
+ Coin realcoin;
+ caches.back()->SpendCoin(data.outpoints[outpointidx], &realcoin);
+ // Apply to simulation data.
+ sim_caches[caches.size()].entry[outpointidx].entrytype = EntryType::SPENT;
+ // Compare *moveto with the value expected based on simulation data.
+ if (!sim.has_value()) {
+ assert(realcoin.IsSpent());
+ } else {
+ assert(!realcoin.IsSpent());
+ const auto& simcoin = data.coins[sim->first];
+ assert(simcoin.out == realcoin.out);
+ assert(simcoin.fCoinBase == realcoin.fCoinBase);
+ assert(realcoin.nHeight == sim->second);
+ }
+ },
+
+ [&]() { // Uncache
+ uint32_t outpointidx = provider.ConsumeIntegralInRange<uint32_t>(0, NUM_OUTPOINTS - 1);
+ // Apply to real caches (there is no equivalent in our simulation).
+ caches.back()->Uncache(data.outpoints[outpointidx]);
+ },
+
+ [&]() { // Add a cache level (if not already at the max).
+ if (caches.size() != MAX_CACHES) {
+ // Apply to real caches.
+ caches.emplace_back(new CCoinsViewCache(&*caches.back(), /*deterministic=*/true));
+ // Apply to simulation data.
+ sim_caches[caches.size()].Wipe();
+ }
+ },
+
+ [&]() { // Remove a cache level.
+ // Apply to real caches (this reduces caches.size(), implicitly doing the same on the simulation data).
+ caches.back()->SanityCheck();
+ caches.pop_back();
+ },
+
+ [&]() { // Flush.
+ // Apply to simulation data.
+ flush();
+ // Apply to real caches.
+ caches.back()->Flush();
+ },
+
+ [&]() { // Sync.
+ // Apply to simulation data (note that in our simulation, syncing and flushing is the same thing).
+ flush();
+ // Apply to real caches.
+ caches.back()->Sync();
+ },
+
+ [&]() { // Flush + ReallocateCache.
+ // Apply to simulation data.
+ flush();
+ // Apply to real caches.
+ caches.back()->Flush();
+ caches.back()->ReallocateCache();
+ },
+
+ [&]() { // GetCacheSize
+ (void)caches.back()->GetCacheSize();
+ },
+
+ [&]() { // DynamicMemoryUsage
+ (void)caches.back()->DynamicMemoryUsage();
+ },
+
+ [&]() { // Change height
+ current_height = provider.ConsumeIntegralInRange<uint32_t>(1, current_height - 1);
+ }
+ );
+ }
+
+ // Sanity check all the remaining caches
+ for (const auto& cache : caches) {
+ cache->SanityCheck();
+ }
+
+ // Full comparison between caches and simulation data, from bottom to top,
+ // as AccessCoin on a higher cache may affect caches below it.
+ for (unsigned sim_idx = 1; sim_idx <= caches.size(); ++sim_idx) {
+ auto& cache = *caches[sim_idx - 1];
+ size_t cache_size = 0;
+
+ for (uint32_t outpointidx = 0; outpointidx < NUM_OUTPOINTS; ++outpointidx) {
+ cache_size += cache.HaveCoinInCache(data.outpoints[outpointidx]);
+ const auto& real = cache.AccessCoin(data.outpoints[outpointidx]);
+ auto sim = lookup(outpointidx, sim_idx);
+ if (!sim.has_value()) {
+ assert(real.IsSpent());
+ } else {
+ assert(!real.IsSpent());
+ assert(real.out == data.coins[sim->first].out);
+ assert(real.fCoinBase == data.coins[sim->first].fCoinBase);
+ assert(real.nHeight == sim->second);
+ }
+ }
+
+ // HaveCoinInCache ignores spent coins, so GetCacheSize() may exceed it. */
+ assert(cache.GetCacheSize() >= cache_size);
+ }
+
+ // Compare the bottom coinsview (not a CCoinsViewCache) with sim_cache[0].
+ for (uint32_t outpointidx = 0; outpointidx < NUM_OUTPOINTS; ++outpointidx) {
+ Coin realcoin;
+ bool real = bottom.GetCoin(data.outpoints[outpointidx], realcoin);
+ auto sim = lookup(outpointidx, 0);
+ if (!sim.has_value()) {
+ assert(!real || realcoin.IsSpent());
+ } else {
+ assert(real && !realcoin.IsSpent());
+ assert(realcoin.out == data.coins[sim->first].out);
+ assert(realcoin.fCoinBase == data.coins[sim->first].fCoinBase);
+ assert(realcoin.nHeight == sim->second);
+ }
+ }
+}
diff --git a/src/util/hasher.cpp b/src/util/hasher.cpp
index a3a3f7a429..81e9b990e1 100644
--- a/src/util/hasher.cpp
+++ b/src/util/hasher.cpp
@@ -9,7 +9,10 @@
SaltedTxidHasher::SaltedTxidHasher() : k0(GetRand<uint64_t>()), k1(GetRand<uint64_t>()) {}
-SaltedOutpointHasher::SaltedOutpointHasher() : k0(GetRand<uint64_t>()), k1(GetRand<uint64_t>()) {}
+SaltedOutpointHasher::SaltedOutpointHasher(bool deterministic) :
+ k0(deterministic ? 0x8e819f2607a18de6 : GetRand<uint64_t>()),
+ k1(deterministic ? 0xf4020d2e3983b0eb : GetRand<uint64_t>())
+{}
SaltedSipHasher::SaltedSipHasher() : m_k0(GetRand<uint64_t>()), m_k1(GetRand<uint64_t>()) {}
diff --git a/src/util/hasher.h b/src/util/hasher.h
index 82d278b086..506ae9415d 100644
--- a/src/util/hasher.h
+++ b/src/util/hasher.h
@@ -36,7 +36,7 @@ private:
const uint64_t k0, k1;
public:
- SaltedOutpointHasher();
+ SaltedOutpointHasher(bool deterministic = false);
/**
* Having the hash noexcept allows libstdc++'s unordered_map to recalculate