aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Toth <andrewstoth@gmail.com>2022-12-06 15:06:03 -0500
committerAndrew Toth <andrewstoth@gmail.com>2022-12-06 15:07:04 -0500
commit7d253c943f44612431be894b198ffb49ff988fff (patch)
treec2f7ffebc26592f7d4f993c7788ead1991135ae2
parentc75e3d2772b00acc3850f72a8cb733a0345aa773 (diff)
downloadbitcoin-7d253c943f44612431be894b198ffb49ff988fff.tar.xz
zmq: remove LOCK(cs_main) from NotifyBlock
-rw-r--r--src/zmq/zmqpublishnotifier.cpp16
1 files changed, 6 insertions, 10 deletions
diff --git a/src/zmq/zmqpublishnotifier.cpp b/src/zmq/zmqpublishnotifier.cpp
index eaf3455296..c785a929d3 100644
--- a/src/zmq/zmqpublishnotifier.cpp
+++ b/src/zmq/zmqpublishnotifier.cpp
@@ -248,18 +248,14 @@ bool CZMQPublishRawBlockNotifier::NotifyBlock(const CBlockIndex *pindex)
const Consensus::Params& consensusParams = Params().GetConsensus();
CDataStream ss(SER_NETWORK, PROTOCOL_VERSION | RPCSerializationFlags());
- {
- LOCK(cs_main);
- CBlock block;
- if(!ReadBlockFromDisk(block, pindex, consensusParams))
- {
- zmqError("Can't read block from disk");
- return false;
- }
-
- ss << block;
+ CBlock block;
+ if (!ReadBlockFromDisk(block, pindex, consensusParams)) {
+ zmqError("Can't read block from disk");
+ return false;
}
+ ss << block;
+
return SendZmqMessage(MSG_RAWBLOCK, &(*ss.begin()), ss.size());
}