diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-12 15:00:18 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-12 15:00:25 +0100 |
| commit | 7649431637441d0e236f33d67eb196bfc33a13a7 (patch) | |
| tree | 5d5093486bc2cf9b38926467ffa3e20affba5dbb | |
| parent | 578f50fc480a5a9028a7e482b1241f2dd2f8eb45 (diff) | |
| parent | fabb419a3caafc00fbbc533fee14fab7a5d2a2c6 (diff) | |
| download | bitcoin-7649431637441d0e236f33d67eb196bfc33a13a7.tar.xz | |
Merge bitcoin/bitcoin#28105: doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC
fabb419a3caafc00fbbc533fee14fab7a5d2a2c6 doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC (MarcoFalke)
Pull request description:
This is a follow-up to commit 7b850bc2a1cd8547a2dbb5a18173f53439601220. While the test case no longer reproduces, the general class of `-fstack-reuse` bugs still exists in all versions of GCC. The workaround can never be removed, unless the whole class of bugs is fixed.
ACKs for top commit:
fanquake:
ACK fabb419a3caafc00fbbc533fee14fab7a5d2a2c6
Tree-SHA512: 566e14fe82d13dda4f7b8cca90c6de75006d14828906b936780716d5b5b31de9b36a904aa7cfc9820ccdfb4d3224a8437f502f25f7230da5abe87c927123f0c8
| -rw-r--r-- | configure.ac | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index fb154e0b43..449d4f9ed1 100644 --- a/configure.ac +++ b/configure.ac @@ -941,9 +941,8 @@ if test "$TARGET_OS" != "windows"; then AX_CHECK_COMPILE_FLAG([-fPIC], [PIC_FLAGS="-fPIC"]) fi -dnl Versions of gcc prior to 12.1 (commit -dnl https://github.com/gcc-mirror/gcc/commit/551aa75778a4c5165d9533cd447c8fc822f583e1) -dnl are subject to a bug, see the gccbug_90348 test case and +dnl Currently all versions of gcc are subject to a class of bugs, see the +dnl gccbug_90348 test case (only reproduces on GCC 11 and earlier) and the related bugs of dnl https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90348. To work around that, set dnl -fstack-reuse=none for all gcc builds. (Only gcc understands this flag) AX_CHECK_COMPILE_FLAG([-fstack-reuse=none], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fstack-reuse=none"]) |