diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-10 09:08:36 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-10 09:08:41 +0100 |
| commit | 6cd1e0f3416fc88240eb37a99a56d2900292f1c0 (patch) | |
| tree | 7a91b7e3a8e4cc8ff9691a84ba99e1ea1289e1f6 | |
| parent | 09ad512369a5ff717518dfb1ed19a45097e65ad3 (diff) | |
| parent | efde11161599deb6d98fb5773c3225d589bb14c2 (diff) | |
| download | bitcoin-6cd1e0f3416fc88240eb37a99a56d2900292f1c0.tar.xz | |
Merge bitcoin/bitcoin#23728: Use the imperative mood in example subject line
efde11161599deb6d98fb5773c3225d589bb14c2 Use the imperative mood in example subject line (Tobin Harding)
Pull request description:
The section `Committing Patches` within `CONTIBUTING.md` contains an example commit subject line that violates rule seven of the linked guide to writing commit logs (Chris Beams famous blog post).
We should practice what we preach, especially in examples :)
Use the imperative mood in example commit message subject line.
ACKs for top commit:
jarolrod:
ACK efde11161599deb6d98fb5773c3225d589bb14c2
shaavan:
ACK efde11161599deb6d98fb5773c3225d589bb14c2
Tree-SHA512: f607951020c544a65df2fcb45f40f10d44bc761298d866ef3d3742c63ed21eed4e7a798c361f8449d05781c04133b60f0b78d4402a8235064953a817bb24c7d0
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index acf5cc08d1..59f662ad34 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -119,7 +119,7 @@ own without warnings, errors, regressions, or test failures. Commit messages should be verbose by default consisting of a short subject line (50 chars max), a blank line and detailed explanatory text as separate -paragraph(s), unless the title alone is self-explanatory (like "Corrected typo +paragraph(s), unless the title alone is self-explanatory (like "Correct typo in init.cpp") in which case a single title line is sufficient. Commit messages should be helpful to people reading your code in the future, so explain the reasoning for your decisions. Further explanation [here](https://chris.beams.io/posts/git-commit/). |