diff options
| author | fanquake <fanquake@gmail.com> | 2022-05-16 14:28:44 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-05-16 14:29:18 +0100 |
| commit | 6b87fa540c407d167535561ac25e3225bf76d6cc (patch) | |
| tree | 71d1602625f5dbe54ed04c16653e6727791f2976 | |
| parent | b019cdc036343a437fd7ced85467bd95f48d84c4 (diff) | |
| parent | fae3200bbf2a0f4482ec6f5f2ada9534f6c82709 (diff) | |
| download | bitcoin-6b87fa540c407d167535561ac25e3225bf76d6cc.tar.xz | |
Merge bitcoin/bitcoin#25125: test: Slim down versionbits_tests.cpp
fae3200bbf2a0f4482ec6f5f2ada9534f6c82709 test: Slim down versionbits_tests.cpp (MacroFake)
Pull request description:
Seems confusing to spin up a full chainman that isn't even used.
Fix that by only spinning up logging. Also, remove the chainman include and comment.
ACKs for top commit:
fanquake:
ACK fae3200bbf2a0f4482ec6f5f2ada9534f6c82709
Tree-SHA512: 35261e9116c0c276f807453db3d635d83916ec2ffd99cf5641f8732736a30a542213096dcec550ef4522d97b3cafe384fdc6068138bc0b577c66fa61256719f8
| -rw-r--r-- | src/test/versionbits_tests.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/test/versionbits_tests.cpp b/src/test/versionbits_tests.cpp index faea0ce7af..129976ec15 100644 --- a/src/test/versionbits_tests.cpp +++ b/src/test/versionbits_tests.cpp @@ -6,7 +6,6 @@ #include <chainparams.h> #include <consensus/params.h> #include <test/util/setup_common.h> -#include <validation.h> #include <versionbits.h> #include <boost/test/unit_test.hpp> @@ -183,7 +182,7 @@ public: CBlockIndex* Tip() { return vpblock.empty() ? nullptr : vpblock.back(); } }; -BOOST_FIXTURE_TEST_SUITE(versionbits_tests, TestingSetup) +BOOST_FIXTURE_TEST_SUITE(versionbits_tests, BasicTestingSetup) BOOST_AUTO_TEST_CASE(versionbits_test) { @@ -413,7 +412,7 @@ static void check_computeblockversion(VersionBitsCache& versionbitscache, const BOOST_AUTO_TEST_CASE(versionbits_computeblockversion) { - VersionBitsCache vbcache; // don't use chainman versionbitscache since we want custom chain params + VersionBitsCache vbcache; // check that any deployment on any chain can conceivably reach both // ACTIVE and FAILED states in roughly the way we expect |