diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2020-12-03 14:43:03 -0500 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2020-12-05 13:50:30 -0500 |
| commit | 6a326cf66f04948ffe729e5540a69e159a7840ad (patch) | |
| tree | 83d040b24a70495d20431946855a62d771af8b92 | |
| parent | 2d48d7dcfb93eeec36dd6f5cbad289b89ec69324 (diff) | |
| download | bitcoin-6a326cf66f04948ffe729e5540a69e159a7840ad.tar.xz | |
tests: Test that a fully signed tx given to signrawtx is unchanged
Tests that a fully signed transaction given to
signrawtransactionwithwallet is both unchanged and marked as complete.
This tests for a regression in 0.20 where the transaction would not be
marked as complete.
Github-Pull: #20562
Rebased-From: 773c42b265fb2212b5cb8785b7226a206d063543
| -rwxr-xr-x | test/functional/rpc_signrawtransaction.py | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/test/functional/rpc_signrawtransaction.py b/test/functional/rpc_signrawtransaction.py index 17686f3a78..d76a29fd99 100755 --- a/test/functional/rpc_signrawtransaction.py +++ b/test/functional/rpc_signrawtransaction.py @@ -146,6 +146,19 @@ class SignRawTransactionsTest(BitcoinTestFramework): assert_equal(rawTxSigned['errors'][1]['witness'], ["304402203609e17b84f6a7d30c80bfa610b5b4542f32a8a0d5447a12fb1366d7f01cc44a0220573a954c4518331561406f90300e8f3358f51928d43c212a8caed02de67eebee01", "025476c2e83188368da1ff3e292e7acafcdb3566bb0ad253f62fc70f07aeee6357"]) assert not rawTxSigned['errors'][0]['witness'] + def test_fully_signed_tx(self): + self.log.info("Test signing a fully signed transaction does nothing") + self.nodes[0].walletpassphrase("password", 9999) + self.nodes[0].generate(101) + rawtx = self.nodes[0].createrawtransaction([], [{self.nodes[0].getnewaddress(): 10}]) + fundedtx = self.nodes[0].fundrawtransaction(rawtx) + signedtx = self.nodes[0].signrawtransactionwithwallet(fundedtx["hex"]) + assert_equal(signedtx["complete"], True) + signedtx2 = self.nodes[0].signrawtransactionwithwallet(signedtx["hex"]) + assert_equal(signedtx2["complete"], True) + assert_equal(signedtx["hex"], signedtx2["hex"]) + self.nodes[0].walletlock() + def witness_script_test(self): # Now test signing transaction to P2SH-P2WSH addresses without wallet # Create a new P2SH-P2WSH 1-of-1 multisig address: @@ -212,6 +225,7 @@ class SignRawTransactionsTest(BitcoinTestFramework): self.script_verification_error_test() self.witness_script_test() self.test_with_lock_outputs() + self.test_fully_signed_tx() if __name__ == '__main__': |