diff options
| author | fanquake <fanquake@gmail.com> | 2023-03-08 08:49:08 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-03-08 08:49:25 +0100 |
| commit | 69ba5727d545edfa3b033bd26ac8e5db2f5cd9e9 (patch) | |
| tree | 8b1e65a3f712ed17523d70bd1508126c1a35be30 | |
| parent | 2de0559f2cb3e02881c0b1a132481fce51a18448 (diff) | |
| parent | 6fc5f4fdb661eb9d42842227501106afcf7111e7 (diff) | |
Merge bitcoin/bitcoin#27180: doc: DummySignInput mention external signer
6fc5f4fdb661eb9d42842227501106afcf7111e7 doc: DummySignInput mention external signer (Sjors Provoost)
Pull request description:
Followups for #26032. So far nothing major.
ACKs for top commit:
ishaanam:
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
S3RK:
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
Tree-SHA512: e27edde9853487fe3eef8213f991aae3724f318bbbe0b11da23759879adaf9a31771e6ea0c30baaebca149032780b89b32aa540ff456ca3d5ec6adb0371749c6
| -rw-r--r-- | src/wallet/wallet.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index e5c03849af..61851ce4ba 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -1648,8 +1648,8 @@ bool DummySignInput(const SigningProvider& provider, CTxIn &tx_in, const CTxOut const CScript& scriptPubKey = txout.scriptPubKey; SignatureData sigdata; - // Use max sig if watch only inputs were used or if this particular input is an external input - // to ensure a sufficient fee is attained for the requested feerate. + // Use max sig if watch only inputs were used, if this particular input is an external input, + // or if this wallet uses an external signer, to ensure a sufficient fee is attained for the requested feerate. const bool use_max_sig = coin_control && (coin_control->fAllowWatchOnly || coin_control->IsExternalSelected(tx_in.prevout) || !can_grind_r); if (!ProduceSignature(provider, use_max_sig ? DUMMY_MAXIMUM_SIGNATURE_CREATOR : DUMMY_SIGNATURE_CREATOR, scriptPubKey, sigdata)) { return false; |