diff options
author | merge-script <fanquake@gmail.com> | 2024-05-02 11:45:23 +0800 |
---|---|---|
committer | merge-script <fanquake@gmail.com> | 2024-05-02 11:45:23 +0800 |
commit | 59b773f42a6730104e13904fb521e52023a997b5 (patch) | |
tree | ef177b25ce638140b3e9f2f911e9061260d81322 | |
parent | 1cc3aa4d21e3e4ff7a651bc71fec062ec5a9eb09 (diff) | |
parent | fa9be2f79520fff9cfe2ed35ace05cb322680af3 (diff) | |
download | bitcoin-59b773f42a6730104e13904fb521e52023a997b5.tar.xz |
Merge bitcoin/bitcoin#30010: lint: [doc] Clarify Windows line endings (CR LF) not to be used
fa9be2f79520fff9cfe2ed35ace05cb322680af3 lint: [doc] Clarify Windows line endings (CR LF) not to be used (MarcoFalke)
Pull request description:
It has been this case since the linter was introduced years ago. Given a misunderstanding (https://github.com/bitcoin/bitcoin/pull/28074#issuecomment-2088028856), clarify the docs.
ACKs for top commit:
brunoerg:
ACK fa9be2f79520fff9cfe2ed35ace05cb322680af3
Tree-SHA512: be714db9df533e0962ed84102ffdb72717902949b930d58cf5a79cba36297f6b2b1f75e65a2c1f46bcb8e2f4ad5d025f3d15210f468a5ec9631a580b74f923ea
-rw-r--r-- | test/lint/test_runner/src/main.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/lint/test_runner/src/main.rs b/test/lint/test_runner/src/main.rs index e22e047e4b..f054f99011 100644 --- a/test/lint/test_runner/src/main.rs +++ b/test/lint/test_runner/src/main.rs @@ -137,9 +137,9 @@ fn lint_trailing_whitespace() -> LintResult { if trailing_space { Err(r#" ^^^ -Trailing whitespace is problematic, because git may warn about it, or editors may remove it by -default, forcing developers in the future to either undo the changes manually or spend time on -review. +Trailing whitespace (including Windows line endings [CR LF]) is problematic, because git may warn +about it, or editors may remove it by default, forcing developers in the future to either undo the +changes manually or spend time on review. Thus, it is best to remove the trailing space now. |