aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames O'Beirne <james.obeirne@gmail.com>2019-06-24 13:57:01 -0400
committerJames O'Beirne <james.obeirne@gmail.com>2019-07-08 11:33:13 -0400
commit55d525ab9004631d30dcc60a1ec5d9cd6c6afe56 (patch)
tree5ee99567d2d6de74378b5db890823cbdfb27bf98
parent4ed55dfcd7894fd5ba6395f244a17ab1f8e786d4 (diff)
refactoring: make pindexBestInvalid internal to validation.cpp
There's no need to have this member live on CChainState since it's only used in validation.cpp.
-rw-r--r--src/validation.cpp2
-rw-r--r--src/validation.h1
2 files changed, 1 insertions, 2 deletions
diff --git a/src/validation.cpp b/src/validation.cpp
index 3e71928d17..0a84a0eec2 100644
--- a/src/validation.cpp
+++ b/src/validation.cpp
@@ -129,7 +129,7 @@ CScript COINBASE_FLAGS;
// Internal stuff
namespace {
- CBlockIndex *&pindexBestInvalid = ::ChainstateActive().pindexBestInvalid;
+ CBlockIndex* pindexBestInvalid = nullptr;
CCriticalSection cs_LastBlockFile;
std::vector<CBlockFileInfo> vinfoBlockFile;
diff --git a/src/validation.h b/src/validation.h
index ab18f662a4..4e971901b8 100644
--- a/src/validation.h
+++ b/src/validation.h
@@ -561,7 +561,6 @@ public:
//! The current chain of blockheaders we consult and build on.
//! @see CChain, CBlockIndex.
CChain m_chain;
- CBlockIndex *pindexBestInvalid = nullptr;
/**
* The set of all CBlockIndex entries with BLOCK_VALID_TRANSACTIONS (for itself and all ancestors) and
* as good as our current tip or better. Entries may be failed, though, and pruning nodes may be