Merge pull request #1646 from Diapolo/only_upd_changed_vals

only update cached values in ClientModel::updateTimer() when they are changed, and set cached values before signal is emitted

1 files changed, 5 insertions, 3 deletions

diff --git a/src/qt/clientmodel.cpp b/src/qt/clientmodel.cpp
index 8fcc4e650e..43bce6f289 100644
--- a/src/qt/clientmodel.cpp
+++ b/src/qt/clientmodel.cpp
@@ -60,10 +60,12 @@ void ClientModel::updateTimer()
     int newNumBlocksOfPeers = getNumBlocksOfPeers();
 
     if(cachedNumBlocks != newNumBlocks || cachedNumBlocksOfPeers != newNumBlocksOfPeers)
-        emit numBlocksChanged(newNumBlocks, newNumBlocksOfPeers);
+    {
+        cachedNumBlocks = newNumBlocks;
+        cachedNumBlocksOfPeers = newNumBlocksOfPeers;
 
-    cachedNumBlocks = newNumBlocks;
-    cachedNumBlocksOfPeers = newNumBlocksOfPeers;
+        emit numBlocksChanged(newNumBlocks, newNumBlocksOfPeers);
+    }
 }
 
 void ClientModel::updateNumConnections(int numConnections)